-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP version 3.0 #61
LSP version 3.0 #61
Conversation
Breaking changes:
|
There is one vague point for me: microsoft/language-server-protocol#165. I will stick to the latest changes in the node implementation and protocol.md: microsoft/vscode-languageserver-node@c97f94a |
@svenefftinge There is a new contract for
We can provide decorators for LanguageServer and LanguageClient which enforce the contract, but it still will be up to clients whether apply decorators or enforce the contract themself. |
window/showMessageRequest request
A review of correspondence to the spec is welcome. |
The initialization contract is something the actual implementers should take care of. |
return this.code; | ||
} | ||
|
||
public void setCode(ResponseErrorCode code) { | ||
public void setCode(int code) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this now an int?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@svenefftinge The protocol says that for requests custom error codes can be defined and there is such for the initialization request in the version 3.0.
No description provided.