Update to guava 33.0.0.jre #782
Conversation
|
Could someone approve the build? This change is analogous to the following: |
| @@ -6,8 +6,8 @@ | |||
| <repository location="https://download.eclipse.org/tools/orbit/simrel/orbit-aggregation/2023-09"/> | |||
| <unit id="com.google.gson" version="2.10.1"/> | |||
| <unit id="com.google.gson.source" version="2.10.1"/> | |||
| <unit id="com.google.guava" version="32.1.2.jre"/> | |||
There was a problem hiding this comment.
i assume you need to split this up into two orbit locations
There was a problem hiding this comment.
There was a problem hiding this comment.
Why do you think that the orbit should be split up here? I want to make sure I don't mess things up in 0.21.2 that I am working on.
There was a problem hiding this comment.
For sure the new version of guava needs 2024-03 to be added...
There was a problem hiding this comment.
I think I answered the question. It is about the renaming of the jakarta.websocket bundles?
There was a problem hiding this comment.
Thanks Ed. I think something is going wrong here as we don't use the older jakarta.websocket, but instead jakarta.websocket-api in the code, so I will look at that.
|
For 2024-03 M1 I think we should just widen the version and do a patch (0.21.2) release like #759 and we can plan on doing an full LSP4J release (0.22.0) in coordination with other projects (like LSP4E and xtext) otherwise we substitute duplicate guava for duplicate lsp4j. I will start working on that now, let me know if you have objections. |
|
plus one from me. then we can release Xtext with the 0.21.2 dependency in case there wont be a release in lsp4j for 2024-03 and lsp4j can then consume the Xtext 2.34 release |
No description provided.