Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#103] Manage External Dependencies #104

Merged
merged 2 commits into from
May 1, 2023
Merged

[#103] Manage External Dependencies #104

merged 2 commits into from
May 1, 2023

Conversation

ruspl-afed
Copy link
Contributor

Remove unnecessary maven egit repo

Isolate EGit Maven repository

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
@wimjongman
Copy link
Member

Hey let me know when to test. I was away for a conference but back again. Just tried to install gh connector but it fails trying to uninstall egit.

@BeckerFrank
Copy link
Contributor

@wimjongman , @ruspl-afed:
I think we can merge this!
I was the last who changed the file so maybe someone else can do the review and merge.

Actual I do a combined test for #104 and #105 on my local env to verify that the update site and installation are ok.

Copy link
Member

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruspl-afed
Copy link
Contributor Author

I cannot add a review/approval since I was a creator.

BTW, how about to allow Project Leads merge without required approval? It may be required for some cases.

@ruspl-afed ruspl-afed merged commit 7043008 into main May 1, 2023
@ruspl-afed ruspl-afed deleted the 103 branch May 1, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants