GitHub task connector #56

BeckerFrank · 2023-02-18T17:55:33Z

See Issue #18 this replaces GitHub Pull request 38

* master: Update Jetty to 9.4.14 Update to Orbit R20190602212107 Change-Id: I0ff2e8c349beeef0b769c548a598f990949408a8 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Change-Id: I31b2299fcfbf24c2f23f85e84680722b4234865d Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Change-Id: I4a07821be768c221ad7a72f7c04b7e5cc059c0b6 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

* stable-5.4: Prepare 5.4.1-SNAPSHOT builds EGit Mylyn Github Connector v5.4.0.201906121030-r Prepare 5.4.0-SNAPSHOT builds EGit Mylyn Github Connector v5.4.0.201905221418-m3 Prepare 5.4.0-SNAPSHOT builds EGit Mylyn Github Connector v5.4.0.201905081430-m2 Change-Id: I81de8e7f1c662eff06233513ece5f5b9c69f3777 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Change-Id: I62930194af501162a41a63cf2c3d4822cdc35a1c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>

Fields that were missing: * After * Created, Deleted, Forced * Base ref * Compare * Distinct size * Head commit * Organization, Pusher, Repository, Sender https://developer.github.com/v3/activity/events/types/#pushevent Bug: 521783 Change-Id: Ibdc22e983aa81ddb638c2fd8ad724ea8957be43f Signed-off-by: Aaron S. Hawley <aaron.s.hawley@gmail.com>

According to [1], mergeable field needs to be a null-able reference type, and not a boolean primitive: The value of the mergeable attribute can be true, false, or null. If the value is null, then GitHub has started a background job to compute the mergeability. After giving the job time to complete, resubmit the request. When the job finishes, you will see a non-null value for the mergeable attribute in the response. [1] https://developer.github.com/v3/pulls/#response-1 Bug: 537774 Change-Id: I0cfb83933afb18386a2390138c738ce78d700a18 Signed-off-by: Aaron S. Hawley <aaron.s.hawley@gmail.com>

To simplify validation in our workspace, use the same placeholders everywhere. Change-Id: I05ecb9ed5123e9f272923a09cdd241ff3f4b3779 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

The singular "/test" is deprecated according to https://developer.github.com/v3/repos/hooks/#test-a-push-hook. That segment is not used anywhere else, so it can be changed without having a copy of the singular version. Bug:548762 Change-Id: Iecd00e422544d4a851e665330c876f2c1cf9ec8c Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

update - Orbit to S20190819183153 - Jetty to 9.4.20.v20190813 - sort entries alphabetically - remove outdated orbit versions Change-Id: Iaaa3663e548c558aa385be43738527ce90ff373e Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Bug: 389656 Change-Id: Ie8246708604a538e731aee2f5af71e1bd95cc69c Signed-off-by: Aaron S. Hawley <aaron.s.hawley@gmail.com>

Change-Id: Ibe9c57f1cd10128fb17d77892ec40262095c4f19 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Change-Id: Ibd1db387a6f1157bf55bebf6f1a6b2bc30d35855 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Change-Id: I00d09a08a55ca01b0b01d5bdfded670ab010c46f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Change-Id: I03c7d56652a7c0f4d4e27df09c04dcbdf4d55015 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

* origin/stable-5.5: Add missing update site URL and name Update Orbit to S20190827152740 for 2019-09 RC1 Prepare 5.5.0-SNAPSHOT builds EGit Mylyn Github Connector v5.5.0.201908280940-m3 Change-Id: I6b464da835b796d7f16bad361ca8e2b521d36355 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>

Change-Id: I32885b5ef96cb0adc092787d5a7f2d7cd4666da7 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>

Change-Id: Iaad841ac43c123a50d50b0a0ea1d7560ab10fc29 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Change-Id: I1bd19561b56109e4b5e4477ca3f504bcfb8fd9f3 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Change-Id: Iadeaed5989a5b1fb60ac83da5bae7ddcea19e47b Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

* stable-5.5: Update Orbit to R20190827152740 for 2019-09 Prepare 5.5.0-SNAPSHOT builds EGit Mylyn Github Connector v5.5.0.201909041048-rc1 Change-Id: Ic002152af0ef3b208b81af58612618d2601a598a Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

The feature description property existed twice in the properties file. Remove the duplicate to avoid further confusion. Change-Id: Ib5eb1e19d896330fc1277377761212d285ce0f0f Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

Change-Id: Ied79b501004d1240c0c3b10f8e8982f45ccbd694 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Change-Id: I82597bebc5492a98e907f0430472521752d5867c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

* stable-5.5: Prepare 5.5.1-SNAPSHOT builds EGit Mylyn Github Connector v5.5.0.201909110433-r Change-Id: I304fddb9efc71bc3b06629c3c014dfbb0eb75cef Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

On recent VMs, collection.toArray(new T[0]) is faster than collection.toArray(new T[collection.size()]). Since it is also more readable, it should now be the preferred way of collection to array conversion. https://shipilev.net/blog/2016/arrays-wisdom-ancients/ Regex used for search: (?s)\Q.toArray(\E\s*new\s+\w+\Q[\E(?!0) Change-Id: I8c20a5b01e2bba4a47e24c6a9bb37e81dd438bd1 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

There is no change in settings. All the newly added lines are the default values (e.g. iterate all project property pages and apply without changing any value). Be aware that the projects currently do not use identical settings everywhere. That can be cleaned up later. Change-Id: Ia6c9b0b1873ed62cedecfeead6822f1700fa72d0 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

Change-Id: Ifd72b88187ff3e5c3188cc301030ba0e405b1e13 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

Have the license feature as part of the target platform and version control it by using the version specific URL. That way rebuilding maintenance branches will always lead to the identical license version, even if a more recent one is globally available. This technique was recommended by Ed via cross platform mailing list. Change-Id: If73a622279f6bf6028c648d52360415eb109af8f Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

Change-Id: I8cbbde20a0b0dea74ad1781c460d662bc83a0b75 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

ruspl-afed

Do we plan to include it to the build?

ruspl-afed · 2023-02-19T06:17:58Z

org.eclipse.mylyn-target/mylyn-e4.26.target

@@ -12,7 +12,7 @@
 			<unit id="org.eclipse.sdk.feature.group" version="0.0.0"/>
 		</location>
 		<location includeAllPlatforms="false" includeConfigurePhase="true" includeMode="planner" includeSource="true" type="InstallableUnit">
-			<repository location="https://download.eclipse.org/egit/updates-6.4/"/>
+			<repository location="https://download.eclipse.org/egit/updates-6.2/"/>


Why do we need to degrade?

I have fixed this. wait for the next commit.

ruspl-afed · 2023-02-19T06:19:22Z

mylyn.github/pom.xml

+
+  <mailingLists>
+    <mailingList>
+      <name>egit-dev Mailing List</name>


Should we switch mail list?

I also changed this and include the GitHub Connector in the maven build and the updatesite.

ruspl-afed · 2023-02-19T06:19:46Z

mylyn.github/pom.xml

+  </mailingLists>
+
+  <issueManagement>
+    <url>https://bugs.eclipse.org/bugs/buglist.cgi?query_format=advanced;product=EGit;component=GitHub</url>


Should we switch issue management?

ruspl-afed · 2023-02-20T06:05:58Z

How can we solve eclipsefdn/eca failure?

wimjongman · 2023-02-21T09:09:32Z

How can we solve eclipsefdn/eca failure?

We have imported existing code from the Egit repo and pushing it now in our repo. With this push, we get an ECA check on an email address from Thomas Wolf.

I have sent a mail to Thomas to ask if he can still sign the ECA with that address. If not, we will accept the code because it comes from an existing valid Eclipse repository, and we still have the history. @waynebeaton Wayne, can you please comment if this is correct?

edit: I got a bounce: Your message wasn't delivered to thomas.wolf@***.ch, so I doubt we can get the ECA signed on this address.

BeckerFrank · 2023-02-21T09:13:04Z

Do we plan to include it to the build?

Yes, I work on tis and hope to finish this soon.

waynebeaton · 2023-02-21T19:41:01Z

Thomas Wolf is a current committer on the Eclipse eGit project. AFAICT all of the current commits attributed to Thomas were made during the period in which he held committer status. Based on the history of his Eclipse account, he changed email addresses sometime since creating those commits. This is why you (and the system) can't find an ECA.

So... you've encountered a hole in the ECA system. I'm pretty sure that we already have an issue open for this. I'll look harder when I have a chance later.

In the meantime, the ECA checker is just warning you of a problem that I'm very confident is bogus, but should not be stopping you. Just merge the commits.

BeckerFrank · 2023-03-05T11:07:35Z

@wimjongman, @ruspl-afed: What is needed to continue here?

wimjongman

It is not perfect yet but I think we should take this and then work on the remaining glitch.

msohn and others added 30 commits June 12, 2019 00:21

Merge branch 'master' into stable-5.4

9f80a1b

* master: Update Jetty to 9.4.14 Update to Orbit R20190602212107 Change-Id: I0ff2e8c349beeef0b769c548a598f990949408a8 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

EGit Mylyn Github Connector v5.4.0.201906121030-r

93a9d5b

Change-Id: I31b2299fcfbf24c2f23f85e84680722b4234865d Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Prepare 5.4.1-SNAPSHOT builds

88084a4

Change-Id: I4a07821be768c221ad7a72f7c04b7e5cc059c0b6 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Prepare 5.5.0-SNAPSHOT builds

0f7592f

Change-Id: I62930194af501162a41a63cf2c3d4822cdc35a1c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com> Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>

unify bundle name placeholders

b63c233

To simplify validation in our workspace, use the same placeholders everywhere. Change-Id: I05ecb9ed5123e9f272923a09cdd241ff3f4b3779 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

Update target platform

e6668d9

update - Orbit to S20190819183153 - Jetty to 9.4.20.v20190813 - sort entries alphabetically - remove outdated orbit versions Change-Id: Iaaa3663e548c558aa385be43738527ce90ff373e Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Add events field to RepositoryHook

dd05ab4

Bug: 389656 Change-Id: Ie8246708604a538e731aee2f5af71e1bd95cc69c Signed-off-by: Aaron S. Hawley <aaron.s.hawley@gmail.com>

EGit Mylyn Github Connector v5.5.0.201908280940-m3

5ef6f33

Change-Id: Ibe9c57f1cd10128fb17d77892ec40262095c4f19 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Prepare 5.5.0-SNAPSHOT builds

c8a8a49

Change-Id: Ibd1db387a6f1157bf55bebf6f1a6b2bc30d35855 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Update Orbit to S20190827152740 for 2019-09 RC1

caabb14

Change-Id: I00d09a08a55ca01b0b01d5bdfded670ab010c46f Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Add missing update site URL and name

6628f20

Change-Id: I03c7d56652a7c0f4d4e27df09c04dcbdf4d55015 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Prepare 5.6.0-SNAPSHOT builds

8e38460

Change-Id: I32885b5ef96cb0adc092787d5a7f2d7cd4666da7 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>

EGit Mylyn Github Connector v5.5.0.201909041048-rc1

5745182

Change-Id: Iaad841ac43c123a50d50b0a0ea1d7560ab10fc29 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Prepare 5.5.0-SNAPSHOT builds

ade8401

Change-Id: I1bd19561b56109e4b5e4477ca3f504bcfb8fd9f3 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Update Orbit to R20190827152740 for 2019-09

f07257f

Change-Id: Iadeaed5989a5b1fb60ac83da5bae7ddcea19e47b Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Merge branch 'stable-5.5'

bd72e0d

* stable-5.5: Update Orbit to R20190827152740 for 2019-09 Prepare 5.5.0-SNAPSHOT builds EGit Mylyn Github Connector v5.5.0.201909041048-rc1 Change-Id: Ic002152af0ef3b208b81af58612618d2601a598a Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Remove duplicate feature description

7d36cf1

The feature description property existed twice in the properties file. Remove the duplicate to avoid further confusion. Change-Id: Ib5eb1e19d896330fc1277377761212d285ce0f0f Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

EGit Mylyn Github Connector v5.5.0.201909110433-r

d6fc842

Change-Id: Ied79b501004d1240c0c3b10f8e8982f45ccbd694 Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Prepare 5.5.1-SNAPSHOT builds

0275466

Change-Id: I82597bebc5492a98e907f0430472521752d5867c Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Merge branch 'stable-5.5'

562d5c5

* stable-5.5: Prepare 5.5.1-SNAPSHOT builds EGit Mylyn Github Connector v5.5.0.201909110433-r Change-Id: I304fddb9efc71bc3b06629c3c014dfbb0eb75cef Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>

Upgrade Jetty to 9.4.21

c5eafc8

Change-Id: Ifd72b88187ff3e5c3188cc301030ba0e405b1e13 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

Upgrade Tycho to 1.5.0

7e644a2

Change-Id: I8cbbde20a0b0dea74ad1781c460d662bc83a0b75 Signed-off-by: Michael Keppler <Michael.Keppler@gmx.de>

wimjongman and others added 8 commits January 6, 2023 13:47

Moved files to mylyn.github

3680892

Merge branch 'mylyn.github' into main

0d59992

removing *.egit.github.core.* as per #18

74fbc58

initial import of github and egit

b231a06

Initial import of github and egit support

3ca351a

Merge branch 'main' into github_2

8b22d76

workaround: add jar org.eclipse.egit.github.core to target platform

9c64965

remove previous workaround

0c441dc

BeckerFrank requested review from wimjongman and ruspl-afed February 18, 2023 17:55

BeckerFrank self-assigned this Feb 18, 2023

BeckerFrank mentioned this pull request Feb 18, 2023

Import of the EGit GitHub connector #38

Closed

ruspl-afed reviewed Feb 19, 2023

View reviewed changes

add egit anf github to maven build

cc134c0

BeckerFrank added 2 commits February 21, 2023 12:53

cleanup maven build for egit and github

9b37eb9

non mac build fix

5b330fa

wimjongman changed the title ~~"Appropriate" GitHub connector in mylyn.tasks~~ GitHub task connector Feb 21, 2023

BeckerFrank added 3 commits February 22, 2023 02:54

resolve conflicts

d32955c

Merge branch 'main' into github_2

8d128f6

Merge branch 'main' into github_2

1ee13bc

BeckerFrank requested a review from ruspl-afed March 18, 2023 10:41

wimjongman approved these changes Mar 18, 2023

View reviewed changes

wimjongman merged commit 577ab95 into main Mar 18, 2023

wimjongman deleted the github_2 branch March 18, 2023 12:21

ruspl-afed mentioned this pull request May 7, 2023

Use consistent bundle and vendor names #128

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub task connector #56

GitHub task connector #56

BeckerFrank commented Feb 18, 2023

ruspl-afed left a comment

ruspl-afed Feb 19, 2023

BeckerFrank Feb 21, 2023

ruspl-afed Feb 19, 2023

wimjongman Feb 20, 2023

BeckerFrank Feb 21, 2023

ruspl-afed Feb 19, 2023

ruspl-afed commented Feb 20, 2023

wimjongman commented Feb 21, 2023 •

edited

Loading

BeckerFrank commented Feb 21, 2023

waynebeaton commented Feb 21, 2023

BeckerFrank commented Mar 5, 2023

wimjongman left a comment

GitHub task connector #56

GitHub task connector #56

Conversation

BeckerFrank commented Feb 18, 2023

ruspl-afed left a comment

Choose a reason for hiding this comment

ruspl-afed Feb 19, 2023

Choose a reason for hiding this comment

BeckerFrank Feb 21, 2023

Choose a reason for hiding this comment

ruspl-afed Feb 19, 2023

Choose a reason for hiding this comment

wimjongman Feb 20, 2023

Choose a reason for hiding this comment

BeckerFrank Feb 21, 2023

Choose a reason for hiding this comment

ruspl-afed Feb 19, 2023

Choose a reason for hiding this comment

ruspl-afed commented Feb 20, 2023

wimjongman commented Feb 21, 2023 • edited Loading

BeckerFrank commented Feb 21, 2023

waynebeaton commented Feb 21, 2023

BeckerFrank commented Mar 5, 2023

wimjongman left a comment

Choose a reason for hiding this comment

wimjongman commented Feb 21, 2023 •

edited

Loading