Authorization/JAXB-API for Jenkins #55, #57 #60

gnl42 · 2023-02-23T07:34:07Z

Added "crumbissuer" authentication. Do we still need the old authentication code?

Fixed missing JAXB-API complaint
(https://www.vogella.com/blog/eclipse-rcp-java-11-jaxb/)

wimjongman

Thanks, George!

This looks good. I found a couple of nits.

...pse.mylyn.hudson.core/src/org/eclipse/mylyn/internal/hudson/core/client/HudsonOperation.java

wimjongman · 2023-02-23T13:33:32Z

...pse.mylyn.hudson.core/src/org/eclipse/mylyn/internal/hudson/core/client/HudsonOperation.java

+
+	}
+
+	@Deprecated


You can drop it.

mylyn.builds/org.eclipse.mylyn.hudson.core/META-INF/MANIFEST.MF

...pse.mylyn.hudson.core/src/org/eclipse/mylyn/internal/hudson/core/client/HudsonOperation.java

ruspl-afed · 2023-02-24T08:51:12Z

mylyn.builds/org.eclipse.mylyn.hudson.core/META-INF/MANIFEST.MF

@@ -4,14 +4,18 @@ Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.mylyn.hudson.core;singleton:=true
 Bundle-Version: 3.26.0.qualifier
 Bundle-Vendor: %Bundle-Vendor
-Require-Bundle: jakarta.xml.bind;bundle-version="2.3.3",
- org.eclipse.core.runtime;bundle-version="0.0.0",
+Require-Bundle: org.eclipse.core.runtime;bundle-version="0.0.0",


Please keep alphabetic order for dependencies

org.eclipse.mylyn-target/mylyn-e4.26.target

gnl42 · 2023-02-24T09:10:53Z

Hi Wim,
I made the changes and had to rework the code a bit to fix some issues I came across after some more testing.

The build framework is weird, I don't understand what the intent was in its design.
CommonHttpClient has an "authenticated" flag that is good for a session, yet has a ThreadLocal variable "context" that is used to store the token. Side effect of this is that each thread had to authenticate rather than just doing it once for the session.

One issue I'm unable to solve is how use the JSESSION id to authenticate when running a build using ones password.
It works fine when using a API token, but according to all the documentation I've come across it should be doable in both cases???

I've been testing it against my local Jenkins instance, and against https://ci.eclipse.org/mylyn/job/github-mylyn/.
If someone who is able to login to ci.eclipse.org could test the code I would feel more comfortable.

Also, I haven't seen any sign that the crumb is needed. Could be my jenkins hasn't been set up fully.

BeckerFrank · 2023-02-24T18:38:14Z

Also, I haven't seen any sign that the crumb is needed. Could be my jenkins hasn't been set up fully.

I have finally remember the password so that I could reactivate the Hudson and Jenkins test instances of the http://mylyn.org domain. Maybe that helps.

This reverts commit 1567f55.

This reverts commit 53dc315.

gnl42 · 2023-02-27T19:11:52Z

Also, I haven't seen any sign that the crumb is needed. Could be my jenkins hasn't been set up fully.

I have finally remember the password so that I could reactivate the Hudson and Jenkins test instances of the http://mylyn.org domain. Maybe that helps.

If that is the same instances that the unit tests are using (e.g.: https://mylyn.org/hudson-3.3.3, http://mylyn.org/jenkins-2.32.3/) it doesn't help.

Neither of them accept the ''crumbIssuer/api/json" request

BeckerFrank · 2023-02-27T19:49:36Z

Maybe the versions are to old to support that or we have never configure this.

gnl42 · 2023-02-28T05:19:06Z

@BeckerFrank

Maybe the versions are to old to support that or we have never configure this.

Looks like 2.32.3 was released back in 2016 so I would say it's too old.
It also hasn't been configured to use the crumb security (CSRF not enabled)

gnl42 · 2023-03-01T09:01:06Z

Hi @wimjongman
I think I've done all I can with this at the moment. The unit tests pass (one is disabled).
The only thing I haven't been able to make work is starting a build using username/pw. Docs say this should be doable when passing crumb AND sessionId but I haven't been able to make it work with my Jenkins instance.
Using user/token works

I would suggest merging the code and deal with any issues that crop up with a new ticket

George

wimjongman · 2023-03-01T09:50:24Z

I would suggest merging the code and deal with any issues that crop up with a new ticket

Hey George. Cool! Do you want to take a look at the review comments before merging?

ruspl-afed

I've removed my comments regarding issues in .target, I need to have closer look later.

gnl42 · 2023-03-01T10:02:18Z

I would suggest merging the code and deal with any issues that crop up with a new ticket

Hey George. Cool! Do you want to take a look at the review comments before merging?

I think I've addressed the comments to the best of my ability. When I tried to address the comments about the .target I ran into unresolved references that I have no idea how to fix

gnl42 · 2023-03-05T07:08:37Z

Don't merge yet. Started looking into the session Id problem and found some very not nice behaviour

gnl42 · 2023-03-07T07:12:30Z

Solved the "sessionId" issue.

user/pw can run build now. Caveat is that if Jenkins is using StrictCrumbIssuer with a timeout set for the crumb one will be unable to run builds once the crumb expires. I can't see any way to have a new crumb created in this situation with how the build framework is designed.
Does not happen with a token, the recommended way, so I'm ok with this behaviour.

wimjongman · 2023-03-07T08:29:58Z

George, is the token used in the password field?

gnl42 · 2023-03-07T09:07:38Z

Hi Wim, yes. It's getting complicated. Depending on the system, authentication can be by: * Token * username/pw * username/token George

…

On 2023-03-07 00:30, Wim Jongman wrote: George, is the token used in the password field? — Reply to this email directly, view it on GitHub <#60 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP36HKKWKYQEAMK4YEUUM23W23WZDANCNFSM6AAAAAAVFIKDPQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

wimjongman · 2023-03-07T09:21:19Z

Yes, it is. To be clear by 'system' do you mean systems like Jenkins or different Jenkins versions? Is the UI still using "Hudson"?

gnl42 · 2023-03-07T17:27:37Z

Yes, * Token: Bamboo 8, GitHub, Jira 8 * username/pw: Bamboo 8, Jenkins, Jira 8 * username/token: Jira 10, Jenkins (modern) The connector is advertised as 'Hudson (supports Jenkins)' but I don't see anything in the UI itself

…

On 2023-03-07 01:21, Wim Jongman wrote: Yes, it is. To be clear by 'system' do you mean systems like Jenkins or different Jenkins versions? Is the UI still using "Hudson"? — Reply to this email directly, view it on GitHub <#60 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AP36HKKAE3NTNRANAN6QT6DW234ZTANCNFSM6AAAAAAVFIKDPQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>

BeckerFrank · 2023-03-09T13:53:50Z

@BeckerFrank

Maybe the versions are to old to support that or we have never configure this.

Looks like 2.32.3 was released back in 2016 so I would say it's too old. It also hasn't been configured to use the crumb security (CSRF not enabled)

Yes we should use a newer Jenkins version in our new test infrastructure (see Multipass setup supports >= 2_303_3)

gnl42 · 2023-03-16T05:37:02Z

Could someone merge the PR?

George Lindholm added 4 commits February 22, 2023 21:33

Hudson Connector - AuthenticationException: Forbidden eclipse-mylyn#57

bad008d

Deal with misbehaving server

8610888

Fix missing JAXB-API problem for Jenkins eclipse-mylyn#55

8778787

Missed anynymous case

7297a85

wimjongman requested changes Feb 23, 2023

View reviewed changes

George Lindholm added 4 commits February 23, 2023 15:27

Make "JSEESIONID" a constant

873124d

Remove old authentication code

b0b9f47

Re-organize package references slightly

de91856

Adjust crumb code.

6b7a936

ruspl-afed requested changes Feb 24, 2023

View reviewed changes

George Lindholm added 3 commits February 24, 2023 00:59

Revert baseUrl manipulation

7bf5968

PR feedback

5519c1c

PR feedback

eceab23

Revert osgi-resource-locator change

b42e011

gnl42 force-pushed the main branch from a8c67ef to b42e011 Compare February 24, 2023 20:25

gnl42 and others added 11 commits February 25, 2023 00:28

Merge branch 'eclipse-mylyn:main' into main

dd475bd

Minor change to the jakarta.activation-api version

1567f55

Need legacy authentication for unit tests

3524d3f

Revert "Minor change to the jakarta.activation-api version"

d10b618

This reverts commit 1567f55.

try () resource

4f1c312

Typo

c1d0c40

Wait a little bit longer in unit test

10fb92f

Enable commented out tests

53dc315

Revert "Enable commented out tests"

5a6568e

This reverts commit 53dc315.

Clean up target file a bit

7841fb3

Merge branch 'eclipse-mylyn:main' into main

725342d

Another stab at getting Hudson unit tests to work

b476215

ruspl-afed approved these changes Mar 1, 2023

View reviewed changes

Modify crumb processing

0fe84d3

Create some constant strings

6aa677f

wimjongman approved these changes Mar 7, 2023

View reviewed changes

ruspl-afed merged commit bddef17 into eclipse-mylyn:main Mar 16, 2023

wimjongman linked an issue Mar 16, 2023 that may be closed by this pull request

Hudson Connector - AuthenticationException: Forbidden #57

Closed

wimjongman added this to the 3.26.0 milestone Mar 16, 2023

wimjongman modified the milestones: 3.26.0, 3.26.1 May 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Authorization/JAXB-API for Jenkins #55, #57 #60

Authorization/JAXB-API for Jenkins #55, #57 #60

gnl42 commented Feb 23, 2023

wimjongman left a comment

wimjongman Feb 23, 2023

ruspl-afed Feb 24, 2023

gnl42 commented Feb 24, 2023

BeckerFrank commented Feb 24, 2023

gnl42 commented Feb 27, 2023

BeckerFrank commented Feb 27, 2023

gnl42 commented Feb 28, 2023

gnl42 commented Mar 1, 2023

wimjongman commented Mar 1, 2023

ruspl-afed left a comment

gnl42 commented Mar 1, 2023

gnl42 commented Mar 5, 2023

gnl42 commented Mar 7, 2023

wimjongman commented Mar 7, 2023

gnl42 commented Mar 7, 2023 via email

wimjongman commented Mar 7, 2023

gnl42 commented Mar 7, 2023 via email

BeckerFrank commented Mar 9, 2023 •

edited

Loading

gnl42 commented Mar 16, 2023

Authorization/JAXB-API for Jenkins #55, #57 #60

Authorization/JAXB-API for Jenkins #55, #57 #60

Conversation

gnl42 commented Feb 23, 2023

wimjongman left a comment

Choose a reason for hiding this comment

wimjongman Feb 23, 2023

Choose a reason for hiding this comment

ruspl-afed Feb 24, 2023

Choose a reason for hiding this comment

gnl42 commented Feb 24, 2023

BeckerFrank commented Feb 24, 2023

gnl42 commented Feb 27, 2023

BeckerFrank commented Feb 27, 2023

gnl42 commented Feb 28, 2023

gnl42 commented Mar 1, 2023

wimjongman commented Mar 1, 2023

ruspl-afed left a comment

Choose a reason for hiding this comment

gnl42 commented Mar 1, 2023

gnl42 commented Mar 5, 2023

gnl42 commented Mar 7, 2023

wimjongman commented Mar 7, 2023

gnl42 commented Mar 7, 2023 via email

wimjongman commented Mar 7, 2023

gnl42 commented Mar 7, 2023 via email

BeckerFrank commented Mar 9, 2023 • edited Loading

gnl42 commented Mar 16, 2023

BeckerFrank commented Mar 9, 2023 •

edited

Loading