Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic for file and data set pattern fields #9

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

paulcheeseman
Copy link
Contributor

This change improves the UI logic for the "dump file pattern" (file) and "data set pattern" (dsn) dump options, based on the following rules:

  1. Only the system dump agent is compatible with the data set pattern field
  2. Dump file pattern and data set pattern cannot be specified at the same time

(The data set pattern is only applicable for z/OS SYSTDUMPS, but this distinction isn't made in the tool.)

Previously, the tool enabled the data set pattern field only if the system dump agent was enabled, but it did not prevent the data set and dump file pattern fields being specified simultaneously - it treated this situation as an error condition and displayed some appropriate text.

With this patch the rules are completely enforced by the UI, which prevents the user from creating an invalid Xdump option. If the user gets into a situation where both pattern fields contain text and both are applicable to the enabled dump types, the dump file pattern (file) option will take precedence.

Signed-off-by: Paul Cheeseman <paul.cheeseman@uk.ibm.com>
@pshipton pshipton merged commit 5719b90 into eclipse-openj9:main Jan 23, 2024
1 check passed
@paulcheeseman paulcheeseman deleted the xdump-filedsnpatterns branch January 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants