Improve logic for file and data set pattern fields #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the UI logic for the "dump file pattern" (
file
) and "data set pattern" (dsn
) dump options, based on the following rules:system
dump agent is compatible with the data set pattern field(The data set pattern is only applicable for z/OS SYSTDUMPS, but this distinction isn't made in the tool.)
Previously, the tool enabled the data set pattern field only if the
system
dump agent was enabled, but it did not prevent the data set and dump file pattern fields being specified simultaneously - it treated this situation as an error condition and displayed some appropriate text.With this patch the rules are completely enforced by the UI, which prevents the user from creating an invalid Xdump option. If the user gets into a situation where both pattern fields contain text and both are applicable to the enabled dump types, the dump file pattern (
file
) option will take precedence.