Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK20 requires implementation of JVM_VirtualThreadHideFrames() #16012

Closed
keithc-ca opened this issue Sep 29, 2022 · 4 comments · Fixed by #16654
Closed

JDK20 requires implementation of JVM_VirtualThreadHideFrames() #16012

keithc-ca opened this issue Sep 29, 2022 · 4 comments · Fixed by #16654

Comments

@keithc-ca
Copy link
Contributor

Uses introduced in 8293613: need to properly handle and hide tmp VTMS transitions.

Staging builds are currently failing (e.g. s390x):

04:49:16  === Output from failing command(s) repeated here ===
04:49:16  * For target support_native_java.base_libjava_BUILD_LIBJAVA_link:
04:49:16  /home/jenkins/workspace/Build_JDKnext_s390x_linux_OpenJDK/build/linux-s390x-server-release/support/native/java.base/libjava/VirtualThread.o:(.data.rel.methods+0x70): undefined reference to `JVM_VirtualThreadHideFrames'
04:49:16  collect2: error: ld returned 1 exit status
@pshipton
Copy link
Member

@tajila @fengxue-IS @babsingh fyi
For now Keith will implement a stub so we can continue building jdk20.

@fengxue-IS
Copy link
Contributor

@thallium is taking a look at this issue

@tajila
Copy link
Contributor

tajila commented Apr 12, 2023

@thallium @fengxue-IS how close is this to completion?

@thallium
Copy link
Contributor

@tajila We are mainly waiting for #16654 to be merged, #17125 is just some refactor.

@tajila tajila modified the milestones: Java 20.0.1 0.39?, Java 20.0.2 Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants