Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEP 384: Record final fields not modifiable through reflection #10259

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

theresa-m
Copy link
Contributor

Related to: #9929
Fix: #9529

  • implement restrictions on record final fields through reflection
  • test that final fields in records cant be modified through reflection
  • test that jdk.internal.misc.Unsafe methods objectFieldOffset/staticFieldOffset/staticFieldBase support records
  • test that there is no record support for VarHandle.set

Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com

Related to: eclipse-openj9#9929
Fix: eclipse-openj9#9529

- implement restrictions on record final fields through reflection
- test that final fields in records cant be modified through reflection
- test that jdk.internal.misc.Unsafe methods objectFieldOffset/staticFieldOffset/staticFieldBase support records
- test that there is no record support for VarHandle.set
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@gacholio
Copy link
Contributor

jenkins test sanity,extended zlinux jdk15

@gacholio
Copy link
Contributor

Test failure appears unrelated to this PR - looks like #10249 (comment)

16:33:31  20:33:31.663 0x198100    j9mm.107    *   ** ASSERTION FAILED ** at CopyForwardScheme.cpp:819: ((false && (newRegion->getReferenceObjectList()->isSoftListEmpty())))

@gacholio gacholio merged commit 660db2e into eclipse-openj9:master Jul 28, 2020
@theresa-m theresa-m deleted the record_reflection branch July 20, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JEP 384 Records (second preview)
3 participants