-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set build variables on the node instead of setup node #10469
Merged
pshipton
merged 1 commit into
eclipse-openj9:master
from
vsebe:ibm-jdk11-jcldev.zos_vars
Aug 27, 2020
Merged
Set build variables on the node instead of setup node #10469
pshipton
merged 1 commit into
eclipse-openj9:master
from
vsebe:ibm-jdk11-jcldev.zos_vars
Aug 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins compile plinux jdk11 |
@jdekonin please review, thank you! |
jdekonin
reviewed
Aug 27, 2020
jdekonin
reviewed
Aug 27, 2020
vsebe
force-pushed
the
ibm-jdk11-jcldev.zos_vars
branch
from
August 27, 2020 17:52
d0f6fe7
to
8445514
Compare
vsebe
changed the title
Set build variables on the node instead of setup node
WIP: Set build variables on the node instead of setup node
Aug 27, 2020
vsebe
force-pushed
the
ibm-jdk11-jcldev.zos_vars
branch
from
August 27, 2020 18:12
8445514
to
c0a75e5
Compare
Set freemarkers, boot_jdk and git cache on the node for correct interpolation and update commands accordingly. Check if locations exist. [ci skip] Signed-off-by: Violeta Sebe <vsebe@ca.ibm.com>
vsebe
force-pushed
the
ibm-jdk11-jcldev.zos_vars
branch
from
August 27, 2020 18:17
c0a75e5
to
584441b
Compare
jdekonin
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
vsebe
changed the title
WIP: Set build variables on the node instead of setup node
Set build variables on the node instead of setup node
Aug 27, 2020
@pshipton please review, thank you! |
Jenkins compile plinux jdk11 |
pshipton
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set freemarkers, boot_jdk and git cache on the node for correct
interpolation and update commands accordingly.
Check if locations exist.
[ci skip]
Signed-off-by: Violeta Sebe vsebe@ca.ibm.com