Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move third party lib to functional level #11368

Merged
merged 1 commit into from
Dec 9, 2020
Merged

move third party lib to functional level #11368

merged 1 commit into from
Dec 9, 2020

Conversation

OscarQQ
Copy link
Contributor

@OscarQQ OscarQQ commented Dec 4, 2020

related: adoptium/TKG#63
[ci skip]

Signed-off-by: OscarQQ Yixin.Qian@ibm.com

@OscarQQ OscarQQ changed the title get third party lib to functional level move third party lib to functional level Dec 4, 2020
@OscarQQ
Copy link
Contributor Author

OscarQQ commented Dec 4, 2020 •
edited
Loading

Grinder_TKG/987 mimic local testing environment, disable Jenkins GetDependency, also remove get all dependency at the beginning OscarQQ/TKG@9d56119
Grinder/12435 mimic local testing environment, just disable Jenkins GetDependency
Grinder/12436 everything other than this commit stays unchanged, get the expected output: all libs with the correct hash

Former pr to move third party lib into functional level (just VM_Test): #11226

vmfarm: job_output id=664510964 getDependentLibs is not called

@OscarQQ
Copy link
Contributor Author

OscarQQ commented Dec 4, 2020

@llxia @renfeiw could you take a review? thanks :)

@llxia llxia added the comp:test label Dec 4, 2020
@llxia
Copy link
Contributor

llxia commented Dec 7, 2020

jenkins test sanity,extended xlinux,win,aix jdk8,jdk11

renfeiw
renfeiw approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OscarQQ
get third dependency in build.xml
7417c5f 
related: adoptium/TKG#63
[ci skip]

Signed-off-by: OscarQQ <Yixin.Qian@ibm.com>
@llxia
Copy link
Contributor

llxia commented Dec 8, 2020

jenkins test sanity,extended xlinux,win,aix jdk8,jdk11

@llxia
Copy link
Contributor

llxia commented Dec 8, 2020

jenkins test extended win jdk11

llxia
llxia approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 2831a5e into eclipse-openj9:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@renfeiw renfeiw renfeiw approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OscarQQ @llxia @renfeiw