(0.24.0) Replace deprecated gethostbyname() with getaddrinfo() to avoid crash #11484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us crash gethostbyname() used in openConnection() (which is used in JITServer code) is known to be non MT safe. We have observed rare crashes in the client JVM, which are likely due to usage of gethostbyname() as explained in eclipse-openj9#11415 This commit replaces the usage of gethostbyname() with gettaddrinfo() which is reentrant and therefore more amenable to multithreaded code. Fixes: eclipse-openj9#11415 Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
|
This is a cherry-pick of PR #11448 into 0.24.0 release branch |
|
@dsouzai Could you please review/merge this PR of mine into 0.24.0 release? Thanks |
|
Straightforward cherrypick, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gethostbyname() used in openConnection() (which is used in JITServer code) is
known to be non MT safe. We have observed rare crashes in the client JVM,
which are likely due to usage of gethostbyname() as explained in #11415
This commit replaces the usage of gethostbyname() with gettaddrinfo() which is
reentrant and therefore more amenable to multithreaded code.
Fixes: #11415
Signed-off-by: Marius Pirvu mpirvu@ca.ibm.com