(0.24.0) Fix utf8 range check in SCC #11498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing check dereferences the utf8 before ensuring that the header is in the SCC. This causes a segfault when the header is not in the SCC. Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
pshipton
changed the title
pshipton
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix utf8 range check in SCC
The existing check dereferences the utf8 before ensuring that the header
is in the SCC. This causes a segfault when the header is not in the SCC.
based on #11487
Signed-off-by: Tobi Ajila atobia@ca.ibm.com