Initial commit for Tag-Repos job #1263
Conversation
AdamBrousseau
force-pushed
the
jenkins_tag_job
branch
from
0382ef0
to
4828a46
Compare
|
|
||
| HTTP = 'https://' | ||
| OMR_REPO = 'github.com/AdamBrousseau/openj9-omr.git' | ||
| OPENJ9_REPO = 'github.com/AdamBrousseau/openj9.git' |
There was a problem hiding this comment.
Will update this to eclipse once done testing
| ) | ||
| echo "SHA: ${SHA}" | ||
| // This 'if' condition is WIP | ||
| if ((TAG_POINT ==~ /.*SHA.*/) || (SHA ==~ /.*TAG_POINT.*/)) { |
There was a problem hiding this comment.
This is the only WIP left for me
AdamBrousseau
force-pushed
the
jenkins_tag_job
branch
2 times, most recently
from
035b608
to
5ca1fe5
Compare
AdamBrousseau
force-pushed
the
jenkins_tag_job
branch
5 times, most recently
from
b22cd13
to
013f2e4
Compare
AdamBrousseau
changed the title
|
Test cases
Ready for review @pshipton |
|
@DanHeidinga do we want to make the Tag Annotation mandatory? Do we have a set format for the annotation? The code would be slightly less complicated if it was mandatory. I'm not sure if the annotation makes a difference from a git checkout perspective. |
|
The command we're using ( |
Yes, the release.md file says to use annotated tags as GITHUB treats them differently than simple tags. The format should be free form text. See #1265 for examples of the annotation I've used for the 0.8.0 release. |
AdamBrousseau
force-pushed
the
jenkins_tag_job
branch
2 times, most recently
from
e2ccef9
to
823f665
Compare
|
Updated to make ANNOTATION mandatory.
|
AdamBrousseau
force-pushed
the
jenkins_tag_job
branch
from
823f665
to
1f4a9e5
Compare
| *******************************************************************************/ | ||
|
|
||
| // Assumes OPENJ9_SHA, OMR_SHA, and TAG_NAME are passed in Jenkins parameters | ||
| // TAG_ANNOTATION is optional |
AdamBrousseau
force-pushed
the
jenkins_tag_job
branch
from
1f4a9e5
to
1e85a83
Compare
| def SHA = sh ( | ||
| script: "git rev-parse --short ${POINT_TYPE_PREFIX}${TAG_POINT}", | ||
| returnStdout: true | ||
| ) |
There was a problem hiding this comment.
Nit: can you adjust the indentation to be consistent with the rest of this file?
| echo "REPO_NAME: ${REPO_NAME}" | ||
|
|
||
| if (STATUS == 128) { | ||
| echo "Good, tag does not exist yet" |
There was a problem hiding this comment.
Where is it documented that 128 is returned in this situation? Do we need to be specific here?
There was a problem hiding this comment.
I can't find it but I see 128 is used for other failure types too. So maybe we should just remove it and take any failure as "tag does not exist"
AdamBrousseau
force-pushed
the
jenkins_tag_job
branch
from
1e85a83
to
32fbb30
Compare
|
updated |
AdamBrousseau
force-pushed
the
jenkins_tag_job
branch
from
32fbb30
to
c5ff04f
Compare
|
Simplified script. Removed the two checks for existing tag and tag_point since having additional checks does not add any value. The git tag command will fail and stderr will indicate what is wrong. |
- Pipeline file to tag OpenJ9 and OpenJ9-OMR - Git tag will fail if tag already exists - Git tag will fail if tag point does not exist - Inputs: Tag Name, Tag Annotation, OpenJ9 SHA, OMR SHA [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
AdamBrousseau
force-pushed
the
jenkins_tag_job
branch
from
c5ff04f
to
c8f9a98
Compare
[skip ci]
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com