Move f2i, f2l, d2i, d2l evaluators from OMR to OpenJ9 #12702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build all xlinux,win,osx jdk8,jdk11 |
|
See copyright check failure: runtime/compiler/x/codegen/J9TreeEvaluator.hpp |
BradleyWood
force-pushed
the
fps
branch
2 times, most recently
from
f7aba38
to
6dcd674
Compare
|
Could you also confirm that you have tested this on Windows and Linux 32-bit please (this would be an IBM-internal JDK8 test run)? |
|
Jenkins test sanity xlinux,win,osx jdk11 |
0xdaryl
requested changes
May 18, 2021
Signed-off-by: BradleyWood <bradley.wood@ibm.com>
|
Done. Sorry, my IDE refuses to cooperate with that style and often changes it on me. |
0xdaryl
approved these changes
May 18, 2021
|
Minor formatting change only. I won't re-run CI. Merging. |
|
Reverting due to #12720 |
This was referenced May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: BradleyWood bradley.wood@ibm.com