Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost readability of dataAddr field sequence on x #13273

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Boost readability of dataAddr field sequence on x #13273

merged 1 commit into from
Aug 26, 2021

Conversation

VermaSh
Copy link
Contributor

@VermaSh VermaSh commented Aug 4, 2021

Add comments to describe the scenarios being captured, and fatal asserts
for the assumptions being made regarding contiguous and discountiguous
header layouts.

dataAddr field sequence refers to the instruction sequence added to JIT
inline array allocation evaluator to update recently added dataAddr
field. The field was added as part of
#11438.

Signed-off-by: Shubham Verma shubhamv.sv@gmail.com

@fjeremic fjeremic self-assigned this Aug 4, 2021
@VermaSh VermaSh force-pushed the jit_inline_array_allocation_x branch from 9de2082 to 99235f3 Compare August 4, 2021 20:20
@fjeremic
Copy link
Contributor

Jenkins test sanity xlinux,win,osx jdk8

@0xdaryl
Copy link
Contributor

0xdaryl commented Aug 11, 2021

Can you expand "sq" in the commit and PR titles please?

@VermaSh VermaSh changed the title Improve readability of dataAddr field sq. on x Improve readability of dataAddr field sequence on x Aug 11, 2021
@VermaSh
Boost readability of dataAddr field sequence on x
6a9dd88 
Add comments to describe the scenarios being captured, and fatal asserts
for the assumptions being made regarding contiguous and discountiguous
header layouts.

dataAddr field sequence refers to the instruction sequence added to JIT
inline array allocation evaluator to update recently added dataAddr
field. The field was added as part of
eclipse-openj9#11438.

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@VermaSh VermaSh force-pushed the jit_inline_array_allocation_x branch from 99235f3 to 6a9dd88 Compare August 11, 2021 14:30
@VermaSh VermaSh changed the title Improve readability of dataAddr field sequence on x Boost readability of dataAddr field sequence on x Aug 11, 2021
@VermaSh
Copy link
Contributor Author

VermaSh commented Aug 11, 2021

Looking into the osx sanity failure. Pasting the failure here for easier reference

+++ j9vm.test.arraycopy.MultiThreadedBackwardArrayCopyTest: +++
command: /Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/openjdkbinary/j2sdk-image/bin/java  -Xcompressedrefs -Xjit -Xgcpolicy:gencon  -Xdump -Xms64m -Xmx64m   -Xbootclasspath:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/openjdkbinary/j2sdk-image/jre/lib/default/jclSC180/vm.jar:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/openjdkbinary/j2sdk-image/jre/lib/se-service.jar:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/openjdkbinary/j2sdk-image/jre/lib/rt.jar:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/openjdkbinary/j2sdk-image/jre/lib/resources.jar:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/openjdkbinary/j2sdk-image/jre/lib/jsse.jar:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/openjdkbinary/j2sdk-image/jre/lib/charsets.jar:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/openjdkbinary/j2sdk-image/jre/lib/jce.jar -classpath /Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/VM_Test/VM_Test.jar:/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/../TKG/lib/asm-all.jar  j9vm.test.arraycopy.MultiThreadedBackwardArrayCopyTest 

EFlags 10602, EFlags & 0x400 = 400, DF flag is set
Unhandled exception
Type=Segmentation error vmState=0x00000000
J9Generic_Signal_Number=00000018 Signal_Number=0000000b Error_Value=00000000 Signal_Code=00000000
Handler1=0000000008C36F70 Handler2=0000000008F0D420
RDI=00000000FF8740C0 RSI=00000000FF8740BC RAX=00000000FF874070 RBX=00000000FF8E01D0
RCX=000000000000000F RDX=0000000000000020 R8=0000000000000640 R9=00000000FF919010
R10=0000000000000022 R11=00000000FF9162F8 R12=00000000FF919010 R13=00000000FF8E01D0
R14=00000000000B4B09 R15=0000000000000000
RIP=0000000017B3F98D GS=0000 FS=0000 RSP=000000000B1BFB10
RFlags=0000000000010602 CS=002B RBP=000000000B1A6C00 ERR=002A000000000000
TRAPNO=000000000000000D CPU=0000000000000000 FAULTVADDR=00007000002A0000
XMM0 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM1 000000000b1bfbb0 (f: 186383280.000000, d: 9.208558e-316)
XMM2 00000000df000000 (f: 3741319168.000000, d: 1.848457e-314)
XMM3 0000000000000010 (f: 16.000000, d: 7.905050e-323)
XMM4 00000000ff919010 (f: 4287729664.000000, d: 2.118420e-314)
XMM5 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM6 3fe1675cababa60e (f: 2880153088.000000, d: 5.438674e-01)
XMM7 402e7f9c1e980fa9 (f: 513281952.000000, d: 1.524924e+01)
XMM8 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM9 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM10 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM11 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM12 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM13 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM14 0000000000000000 (f: 0.000000, d: 0.000000e+00)
XMM15 0000000000000000 (f: 0.000000, d: 0.000000e+00)

Compiled_method=j9vm/test/arraycopy/MultiThreadedBackwardArrayCopyTest.rotateSource()V
Target=2_90_20210810_97 (Mac OS X 10.11.6)
CPU=amd64 (4 logical CPUs) (0x200000000 RAM)
----------- Stack Backtrace -----------
---------------------------------------
JVMDUMP039I Processing dump event "gpf", detail "" at 2021/08/10 18:22:40 - please wait.
JVMDUMP032I JVM requested System dump using '/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/output_16286307849654/J9vmTest_5/core.20210810.182240.50328.0001.dmp' in response to an event
JVMDUMP010I System dump written to /Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/output_16286307849654/J9vmTest_5/core.20210810.182240.50328.0001.dmp
JVMDUMP032I JVM requested Java dump using '/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/output_16286307849654/J9vmTest_5/javacore.20210810.182240.50328.0002.txt' in response to an event
JVMDUMP010I Java dump written to /Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/output_16286307849654/J9vmTest_5/javacore.20210810.182240.50328.0002.txt
JVMDUMP032I JVM requested Snap dump using '/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/output_16286307849654/J9vmTest_5/Snap.20210810.182240.50328.0003.trc' in response to an event
JVMDUMP010I Snap dump written to /Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/output_16286307849654/J9vmTest_5/Snap.20210810.182240.50328.0003.trc
JVMDUMP032I JVM requested JIT dump using '/Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/output_16286307849654/J9vmTest_5/jitdump.20210810.182240.50328.0004.dmp' in response to an event
JVMDUMP051I JIT dump occurred in 'Thread-4' thread 0x000000000B1A6C00
JVMDUMP053I JIT dump is recompiling j9vm/test/arraycopy/MultiThreadedBackwardArrayCopyTest.rotateSource()V
JVMDUMP053I JIT dump is recompiling j9vm/test/arraycopy/MultiThreadedBackwardArrayCopyTest.rotateSource()V
JVMDUMP010I JIT dump written to /Users/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_mac_Personal_testList_0/aqa-tests/TKG/output_16286307849654/J9vmTest_5/jitdump.20210810.182240.50328.0004.dmp
JVMDUMP013I Processed dump event "gpf", detail "".
no-zero exit value: 255
*** Test FAILED *** (j9vm.test.arraycopy.MultiThreadedBackwardArrayCopyTest)

@VermaSh
Copy link
Contributor Author

VermaSh commented Aug 11, 2021

The failures is related to #9782. Since that was the only failure we should be good here.

@fjeremic
Copy link
Contributor

Jenkins test sanity xlinux,win,osx jdk8

@fjeremic fjeremic merged commit 24a42f0 into eclipse-openj9:master Aug 26, 2021
@VermaSh VermaSh deleted the jit_inline_array_allocation_x branch September 9, 2021 17:48
VermaSh added a commit to VermaSh/openj9 that referenced this pull request Nov 24, 2022
@VermaSh
Revert "Merge pull request eclipse-openj9#13273 from VermaSh/jit_inli…
8e6feef 
…ne_array_allocation_x"

This reverts commit 24a42f0, reversing
changes made to 689da7e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjeremic fjeremic fjeremic approved these changes

Assignees

@fjeremic fjeremic

Labels
arch:x86 comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VermaSh @fjeremic @0xdaryl