JVMTI trigger VMStart event according to can_generate_early_vmstart #13737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonFengJ9
force-pushed
the
earlyvmstart
branch
from
12627a8
to
96eb164
Compare
|
We must be missing a test as well, since this problem went unnoticed. |
This PR is aimed for |
|
A separate PR is fine. It's too late for 0.29.0, and we'll see about 0.29.1. |
gacholio
reviewed
Oct 20, 2021
Moved TRIGGER_J9HOOK_JAVA_BASE_LOADED to standardInit() after initializeAttachedThread() for mainThread, which is the earliest point to run an agent such as YourKit Java profiler agent; Fixed processEvent() for J9HOOK_JAVA_BASE_LOADED; When can_generate_early_vmstart capability is specified, VMStart event is triggered in the jvmtiHookModuleSystemStarted handler, otherwise in jvmtiHookVMStarted after JavaVM initialization; Refactoring the functions affected, replaced JAVA_SPEC_VERSION 9 with 11. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
JasonFengJ9
force-pushed
the
earlyvmstart
branch
from
96eb164
to
d05b6e8
Compare
gacholio
approved these changes
Oct 20, 2021
|
jenkins test sanity zlinux jdk8,jdk11 |
|
jenkins compile win jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
TRIGGER_J9HOOK_JAVA_BASE_LOADEDtostandardInit()afterinitializeAttachedThread()formainThread, which is the earliest point to run an agent such asYourKit Java profileragent;Fixed
processEvent()forJ9HOOK_JAVA_BASE_LOADED;When
can_generate_early_vmstartcapability is specified,VMStartevent is triggered in thejvmtiHookModuleSystemStartedhandler, otherwise injvmtiHookVMStartedafter JavaVM initialization;Refactoring the functions affected, replaced
JAVA_SPEC_VERSION9with11.issue #13708
Signed-off-by: Jason Feng fengj@ca.ibm.com