Extract the obfuscation change logs from build

[gregorycernera]

Signed-off-by: Gregory-Cernera gregory.cernera@ibm.com

Features/changes

• Extract any files that match the pattern ObfuscateLog*.txt to Artifactory
• Add the file's Artifactory links to the Jenkins description for easy download.

Reason for changes

• With the addition of the obfuscation in the build process, we need to be able to grab the change log files for future reference (i.e., customer cases).

[gregorycernera]

FYI @joransiu @keithc-ca @pshipton

[DanHeidinga]

As someone not aware of what this is for, it feels like a very IBM-specific change to be making to the OpenJ9 project. Is there a better way to factor this that keeps it either more broadly applicable or hosts it inside IBM?

fyi @pshipton

[pshipton]

It's collecting obfuscation logs. Perhaps it can be made more generic, to look for all files with a certain name pattern, rather than the IBM specific files.

[gregorycernera]

Also the tests if (!zelixFiles.isEmpty()) are redundant (here and above): the for loops will just execute zero times if that list is empty.

Fixed

[keithc-ca]

@DanHeidinga Has the generalization of this addressed your concerns?

[keithc-ca]

@DanHeidinga Has the generalization of this addressed your concerns?

@DanHeidinga?

[DanHeidinga]

Sorry @keithc-ca - I missed the original poke on this. Yes, the changes make this more general. Thanks for addressing this!

[keithc-ca]

@gregorycernera I think the commit message and the description of this pull request should be updated to refer to "obfuscation log" rather than "Zelix logs" to match the result.

[gregorycernera]

@gregorycernera I think the commit message and the description of this pull request should be updated to refer to "obfuscation log" rather than "Zelix logs" to match the result.

okay hang on, my commits got messed up. I'm fixing and rebasing now, I'll let you know when it's good to go @keithc-ca

[gregorycernera]

@keithc-ca, we're good to go 👍