Refactor CRIUConfigurator #15047
Merged
Refactor CRIUConfigurator #15047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajila
force-pushed
the
criu
branch
2 times, most recently
from
30b2df2
to
8f903c5
Compare
|
Jenkins compile xlinuxcriu jdk11 |
keithc-ca
requested changes
May 11, 2022
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
keithc-ca
reviewed
May 11, 2022
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
keithc-ca
reviewed
May 11, 2022
jcl/src/java.base/share/classes/openj9/internal/criu/security/CRIUConfigurator.java
Outdated
Show resolved
Hide resolved
Move CRIUConfigurator to a new package that is only exported to openj9.criu Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
|
I've addressed the compilation and indentation issues |
keithc-ca
approved these changes
May 12, 2022
|
jenkins compile osx,xlinuxcriu jdk11 |
|
jenkins compile xlinuxcriu jdk11 depends ibmruntimes/openj9-openjdk-jdk11#523 |
|
For the record, both builds were successful: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor CRIUConfigurator
Move CRIUConfigurator to a new package that is only exported to
openj9.criu
Signed-off-by: Tobi Ajila atobia@ca.ibm.com