Fix setEventNotificationMode for unmounted virtual threads #15969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targetThread is NULL only for virtual threads, as per the assertion in getVMThread, when mustBeAlive is TRUE. vmThreadForTLS is only used to acquire J9JavaVM in createThreadData and jvmtiTLSGet. If targetThread is NULL, currentThread is passed to createThreadData and jvmtiTLSGet for retrieving J9JavaVM in JDK19+. Related: eclipse-openj9#15541 Related: eclipse-openj9#15183 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
|
@gacholio Can you please review it? |
gacholio
approved these changes
Sep 27, 2022
|
jenkins test sanity xlinux jdk19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targetThread is NULL only for virtual threads, as per the assertion in
getVMThread, when mustBeAlive is TRUE. vmThreadForTLS is only
used to acquire J9JavaVM in createThreadData and jvmtiTLSGet.
If targetThread is NULL, currentThread is passed to createThreadData
and jvmtiTLSGet for retrieving J9JavaVM in JDK19+.
Related: #15541
Related: #15183
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com