Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setEventNotificationMode for unmounted virtual threads #15969

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

babsingh
Copy link
Contributor

targetThread is NULL only for virtual threads, as per the assertion in
getVMThread, when mustBeAlive is TRUE. vmThreadForTLS is only
used to acquire J9JavaVM in createThreadData and jvmtiTLSGet.
If targetThread is NULL, currentThread is passed to createThreadData
and jvmtiTLSGet for retrieving J9JavaVM in JDK19+.

Related: #15541
Related: #15183

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

targetThread is NULL only for virtual threads, as per the assertion in
getVMThread, when mustBeAlive is TRUE. vmThreadForTLS is only used to
acquire J9JavaVM in createThreadData and jvmtiTLSGet. If targetThread
is NULL, currentThread is passed to createThreadData and jvmtiTLSGet
for retrieving J9JavaVM in JDK19+.

Related: eclipse-openj9#15541
Related: eclipse-openj9#15183

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
Copy link
Contributor

@fengxue-IS fengxue-IS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengxue-IS fengxue-IS added the project:loom Used to track Project Loom related work label Sep 26, 2022
@babsingh
Copy link
Contributor Author

@gacholio Can you please review it?

@gacholio
Copy link
Contributor

jenkins test sanity xlinux jdk19

@gacholio gacholio merged commit 4f98799 into eclipse-openj9:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project:loom Used to track Project Loom related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants