Don't inline StringLatin1.inflate when array lets can be generated

[dchopra001]

When balanced GC policy is in effect, array lets can be generated. The codegen optimization where we inline StringLatin1.inflate is not compatible in such a scenario. Therefore, this PR disables that optimization when arraylets can be generated.

[dchopra001]

Tagging @r30shah @VermaSh for reviews.

[VermaSh]

Looks good. Thank you @dchopra001!

[r30shah]

@dchopra001 As this PR resolves the failures seen on Linux on Z (#17203), can you update the commit/description to tag this once closing the 17203 issue ?

[r30shah]

@joransiu Can I request you to review and merge this PR?

[joransiu]

jenkins test sanity zlinux jdk11,jdk17

[VermaSh]

@joransiu can you please run sanity tests for jdk20 as well?

[joransiu]

jenkins test sanity zlinux jdk11,jdk17,jdk20

[pshipton]

I'll run the suite that failed.

jenkins test sanity.openjdk zlinux jdk11,jdk17,jdk20

[joransiu]

Hmm, we're seeing failures in JCL_Test_* with the following assertion:

        Exception in thread "no-op thread" org.openj9.test.java.lang.Test_ThreadGroup$1UncaughtException
        	at org.openj9.test.java.lang.Test_ThreadGroup$13.uncaughtException(Test_ThreadGroup.java:972) from jdk.internal.loader.ClassLoaders$AppClassLoader@96bd042f(file:/home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_s390x_linux_Personal_testList_0/jvmtest/functional/Java8andUp/GeneralTest.jar)
        	at java.base/java.lang.Thread.uncaughtException(Thread.java:1363) from jrt:/java.base
        org.openj9.test.java.lang.Test_Throwable$TestException: test
        22:31:49.278 0xc44c00    j9vm.228    *   ** ASSERTION FAILED ** at /home/jenkins/workspace/Build_JDK11_s390x_linux_Personal/openj9/runtime/vm/VMAccess.cpp:355: (0 == ((vmThread)->publicFlags & J9_PUBLIC_FLAGS_VM_ACCESS))
        JVMDUMP039I Processing dump event "traceassert", detail "" at 2023/05/03 22:31:49 - please wait.
        JVMDUMP032I JVM requested System dump using '/home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/output_16831493189313/JCL_Test_none_SCC_0/core.20230503.223149.3278298.0001.dmp' in response to an event
        JVMDUMP010I System dump written to /home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/output_16831493189313/JCL_Test_none_SCC_0/core.20230503.223149.3278298.0001.dmp
        JVMDUMP032I JVM requested Java dump using '/home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/output_16831493189313/JCL_Test_none_SCC_0/javacore.20230503.223149.3278298.0002.txt' in response to an event
        JVMDUMP010I Java dump written to /home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/output_16831493189313/JCL_Test_none_SCC_0/javacore.20230503.223149.3278298.0002.txt
        JVMDUMP032I JVM requested Snap dump using '/home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/output_16831493189313/JCL_Test_none_SCC_0/Snap.20230503.223149.3278298.0003.trc' in response to an event
        JVMDUMP010I Snap dump written to /home/jenkins/workspace/Test_openjdk11_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/output_16831493189313/JCL_Test_none_SCC_0/Snap.20230503.223149.3278298.0003.trc
        JVMDUMP013I Processed dump event "traceassert", detail "".

Not seeing why it would be triggered by this change.

[pshipton]

We're also seeing that in the OMR acceptance build, https://openj9.slack.com/archives/CDS7QE9HB/p1683147702449159
I thought it was due to an OMR change, but there must be something I missed.

[pshipton]

Created #17334, we'll get the bad change fixed or reverted tomorrow.

[pshipton]

The bad change was reverted. You can decide if you want to re-run testing or proceed with the merge.

[joransiu]

The bad change was reverted. You can decide if you want to re-run testing or proceed with the merge.

Thanks @pshipton for tracking that issue down. Will go ahead with the merge, given all the remaining tests are passing, and the scope of this change is limited and well defined.