Remove the space at the end of J9NLS_VM_STACK_TRACE_EXCEPTION_IN, update all NLS translations #18446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
force-pushed
the
space
branch
2 times, most recently
from
fa6b1b6
to
9c10990
Compare
|
I think I could just modify the existing message in place. Thoughts? |
|
I've pushed the change. If you agree I will squash the two commits. |
keithc-ca
reviewed
Nov 13, 2023
|
Updated it. |
keithc-ca
reviewed
Nov 13, 2023
keithc-ca
reviewed
Nov 13, 2023
pshipton
changed the title
Avoid having a message with a space at the end to keep the line endings check happy. Explicitly print the space in the code. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
Jenkins compile alinux jdk17 |
keithc-ca
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid having a message with a space at the end to keep the line endings check happy. Explicitly print the space in the code.
Also update all the NLS translations.