Disclaim Cold Code Cache #19397
Disclaim Cold Code Cache #19397
Conversation
gita-omr
commented
Apr 26, 2024
•
gita-omr
commented
- use the same heuristcs for code cache disclaim as for data cache
- disclaim starting from the cold code
- move stack overflow outline instructions into the warm area to increase disclaim efficiency
- code is enabled with -Xjit:enableCodeCacheDisclaiming
gita-omr
force-pushed
the
disclaim_cold_cache
branch
from
bc551a6
to
f088c14
Compare
|
Fixed line endings |
gita-omr
force-pushed
the
disclaim_cold_cache
branch
from
f088c14
to
c58500a
Compare
|
Fixed EOF. |
|
Addressed comments above. |
gita-omr
force-pushed
the
disclaim_cold_cache
branch
from
709a70c
to
1f360da
Compare
|
Fixed line ending. |
|
Removed dependence on eclipse-omr/omr#7300 since it's been merged. |
|
Added commit to put thunks into warm code cache. |
gita-omr
added this to the Release 0.46 (Java 8, 11, 17, 21, 22) July refresh milestone
|
Line ending check is not related to my change - many test files are reported. |
gita-omr
force-pushed
the
disclaim_cold_cache
branch
from
d39b396
to
b615ea6
Compare
|
Addressed latest comments. |
| } | ||
| else if (TR::Options::getCmdLineOptions()->getVerboseOption(TR_VerbosePerformance)) | ||
| { | ||
| TR_VerboseLog::writeLineLocked(TR_Vlog_INFO, "In code cache %p small pages start from %p\n", this, middle); |
There was a problem hiding this comment.
I would prefer this message to be more explicit. I am trying to imagine what a casual consumer of verbose logs would understand when it sees this message among all the other others.
Suggestion: "Forcing code cache cold region %p-%p to use default size memory pages"
gita-omr
force-pushed
the
disclaim_cold_cache
branch
from
b615ea6
to
2a41998
Compare
|
Addressed latest comment. |
gita-omr
force-pushed
the
disclaim_cold_cache
branch
from
2a41998
to
3eee070
Compare
|
Squashed the commits. |
|
Trailing spaces are not due to this PR. |
|
Could you please rebase to eliminate conflicts? |
- use the same heuristcs for code cache disclaim as for data cache - disclaim starting from the cold code - move stack overflow outline instructions into the warm area to increase disclaim efficiency - code is enabled with -Xjit:enableCodeCacheDisclaiming
gita-omr
force-pushed
the
disclaim_cold_cache
branch
from
3eee070
to
c3c689a
Compare
|
Rebased. |
There was a problem hiding this comment.
LGTM.
I have a question though: have you tested what happens when large pages are enabled on the system?
I have seen that VM code uses shmat instead of mmap when large pages are configured on the system. I would assume that disclaiming is not going to work in that case. Do we take steps to disable it?
|
jenkins test sanity all jdk17 |
Good question. I did not try it on the system with large pages. I will take a note and open another PR. This PR is just the core code. I was planning to do more tuning and enable it by default eventually. |
|
jenkins compile win jdk17 |
