Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "for" loop from range-based to iterator based #19465

Merged
merged 1 commit into from
May 8, 2024

Conversation

mpirvu
Copy link
Contributor

@mpirvu mpirvu commented May 8, 2024

Rationale: Older compilers do not understand the range-based loop even though it's part of the C++-11 standard.

Rationale: Older compilers do not understand the range-based loop
even though it's part of the C++-11 standard.

Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
@mpirvu mpirvu added the comp:jit label May 8, 2024
@mpirvu mpirvu requested a review from dsouzai as a code owner May 8, 2024 14:07
@mpirvu
Copy link
Contributor Author

mpirvu commented May 8, 2024

Internal build is passing: http://vmfarm.rtp.raleigh.ibm.com/build_info.php?build_id=70767

@mpirvu
Copy link
Contributor Author

mpirvu commented May 8, 2024

jenkins test sanity zlinux jdk17

Copy link
Member

@ymanton ymanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ymanton ymanton merged commit c58b9f8 into eclipse-openj9:master May 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants