Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DDR Command: FindInstances #19651

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Implement DDR Command: FindInstances #19651

merged 1 commit into from
Jul 16, 2024

Conversation

babsingh
Copy link
Contributor

@babsingh babsingh commented Jun 7, 2024

Related: #19267

@babsingh babsingh force-pushed the main6 branch 2 times, most recently from c409866 to dfd6861 Compare June 7, 2024 14:27
@keithc-ca keithc-ca self-requested a review June 21, 2024 14:18
keithc-ca
keithc-ca requested changes Jul 10, 2024
View reviewed changes
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/commands/FindInstances.java Outdated Show resolved Hide resolved
@babsingh babsingh force-pushed the main6 branch 2 times, most recently from 9a0f809 to 3b14b6f Compare July 10, 2024 21:59
@babsingh
Copy link
Contributor Author

@keithc-ca I have addressed all of your feedback.

@babsingh
Implement DDR Command: FindInstances
76c32af 
Related: eclipse-openj9#19267

Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh
Copy link
Contributor Author

@keithc-ca The last two points have been addressed.

@keithc-ca
Copy link
Contributor

Jenkins test sanity zlinux jdk17

@keithc-ca keithc-ca merged commit 680988e into eclipse-openj9:master Jul 16, 2024
5 checks passed
@babsingh babsingh mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThanHenderson ThanHenderson ThanHenderson left review comments

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babsingh @keithc-ca @ThanHenderson