Add implementation of String.lines() (jdk11 only) #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikser
changed the title
|
@tajila fyi |
anikser
force-pushed
the
string-lines-jdk11
branch
2 times, most recently
from
9161cec
to
1401afe
Compare
added 2 commits
July 24, 2018 11:16
This change adds an implementation of String.lines(), which returns a lazily supplied Stream of Strings broken up by line terminators. Signed-off-by: Mohammad Ali Nikseresht <anikser@ibm.com>
This change adds test cases for String.lines(). This change only affects Java 11. Signed-off-by: Mohammad Ali Nikseresht <anikser@ibm.com>
anikser
force-pushed
the
string-lines-jdk11
branch
from
1401afe
to
1230c9c
Compare
|
lgtm @fjeremic can you please review |
fjeremic
approved these changes
Jul 25, 2018
|
We don't have JDK11 tests so omitting Jenkins builds here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an implementation of String.lines(), which returns
a lazily supplied Stream of Strings broken up by line terminators.
This change only affects Java 11.
Closes: #2109
Signed-off-by: Mohammad Ali Nikseresht anikser@ibm.com