Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add j9 include path to uma includes for resource compilation #344

Merged
merged 1 commit into from
Oct 17, 2017

Conversation

vsebe
Copy link
Contributor

@vsebe vsebe commented Oct 16, 2017

Issues: #55

Signed-off-by: Violeta Sebe vsebe@ca.ibm.com

Signed-off-by: Violeta Sebe <vsebe@ca.ibm.com>
@keithc-ca
Copy link
Contributor

Which header files are not found if the additional include directory is omitted?

@vsebe
Copy link
Contributor Author

vsebe commented Oct 16, 2017

@keithc-ca: j9cfg.h

/usr/bin/make -j 8 -C ./win_64 -f makefile
make[5]: warning: -jN forced in submake: disabling jobserver mode.
make[5]: Entering directory '/cygdrive/c/tmp/openj9-openjdk-jdk9/build/windows-x86_64-normal-server-release/vm'
cl -DJAVA_SPEC_VERSION=9 /Ox /GS- -D_AMD64_=1 -DWIN64 -D_WIN64 -DWIN32 -D_WIN32 -DJ9HAMMER -Fdcopyright.pdb -D_CRT_SECURE_NO_WARNINGS -DCRTAPI1=_cdecl -DCRTAPI2=_cdecl -nologo -D_WIN95 -D_WIN32_WINDOWS=0x0500 /D_WIN32_DCOM -D_WIN32_IE=0x0500 -DWINVER=0x0501 -D_WIN32_WINNT=0x0501 -D_MT -D_WINSOCKAPI_ -Zm400 -W3 -Zi -MD -D_DLL /I. /I../nls /I../omr/include_core    -DUT_DIRECT_TRACE_REGISTRATION -DTR_HOST_X86 -c ../makelib/copyright.c
rc /I. /I../nls /I../omr/include_core  win_64.rc
copyright.c
Microsoft (R) Windows (R) Resource Compiler Version 6.3.9600.17336

Copyright (C) Microsoft Corporation.  All rights reserved.


win_64.rc(4) : fatal error RC1015: cannot open include file 'j9cfg.h'.

make[5]: *** [../makelib/targets.mk:367: win_64.res] Error 1

@keithc-ca
Copy link
Contributor

Ok, I should have also asked (explicitly) which files suffer because of this?

@keithc-ca keithc-ca merged commit 3c9c53c into eclipse-openj9:master Oct 17, 2017
@vsebe vsebe deleted the openj9.win_64 branch October 20, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants