Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Update atomic configuration #8316

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

dnakamura
Copy link
Contributor

  • Add J9VM_INTERP_ATOMIC_FREE_JNI_USES_FLUSH option
  • Add J9VM_INTERP_TWO_PASS_EXCLUSIVE
  • Enable both on all cmake builds
  • Enable J9VM_INTERP_ATOMIC_FREE_JNI on all cmake builds

Signed-off-by: Devin Nakamura devinn@ca.ibm.com

@dnakamura dnakamura force-pushed the atomic_free branch 2 times, most recently from e6cb192 to 97aae24 Compare January 16, 2020 18:32
buildspecs/j9.flags Show resolved Hide resolved
runtime/cmake/caches/common.cmake Outdated Show resolved Hide resolved
@dnakamura
Copy link
Contributor Author

@DanHeidinga This should be ready to go now

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga
Copy link
Member

Jenkins test sanity plinuxcm jdk11

@DanHeidinga DanHeidinga self-assigned this Jan 27, 2020
@DanHeidinga
Copy link
Member

Jenkins test sanity xlinuxcm jdk11

@DanHeidinga
Copy link
Member

@dnakamura Can you rebase this and then I'll rerun the PR testing before merging

- Add J9VM_INTERP_ATOMIC_FREE_JNI_USES_FLUSH option
- Add J9VM_INTERP_TWO_PASS_EXCLUSIVE
- Enable both on all cmake builds
- Enable J9VM_INTERP_ATOMIC_FREE_JNI on all cmake builds

Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
@DanHeidinga
Copy link
Member

Jenkins test sanity xlinuxcm,plinuxcm jdk11

@DanHeidinga
Copy link
Member

Jenkins test sanity xlinuxcm jdk11

Relaunching the build as the plinuxcm spec wasn't enabled yet

@DanHeidinga DanHeidinga merged commit 8acaaba into eclipse-openj9:master Mar 5, 2020
@dnakamura dnakamura deleted the atomic_free branch April 7, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants