(0.20.0) Partial MethodType created by readObject can be used #9245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the serialized MethodType contains objects which have their own readObject method, whether from extra items in the serialized form or from the return type or argumens fields, then the bogus MethodType object created will be accessible from the other readObject methods, with possibly incomplete type information. This commit adds copies of the arguments and return type fields for use in serialization, and sets the actual type to "()V" until readResolve is called and creates a useable MethodType. Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
Set methodDescriptor string and stackDescriptionBits in case the temporary object is accessed. Signed-off-by: Mike Zhang <mike.h.zhang@ibm.com>
Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
already merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the serialized MethodType contains objects which have their own readObject
method, whether from extra items in the serialized form or from the return
type or argumens fields, then the bogus MethodType object created will be
accessible from the other readObject methods, with possibly incomplete type
information.
This commit adds copies of the arguments and return type fields for use in
serialization, and sets the actual type to "()V" until readResolve is called
and creates a useable MethodType.
Set methodDescriptor string and stackDescriptionBits in case the temporary
object is accessed.
Cherry pick of the commits in #9244 for the 0.20.0 release.