(0.21.0) Fix a couple minor issues with 16-bit immediates on Power #9819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was one location where the offset of the lockword used in an li instruction was masked to include only the bottom 16 bits. While this is currently correct AFAIK, since it can never be negative and cannot currently exceed 0x7fff legitimately, it may cause the assert on the range of the immediate to be silenced incorrectly should this change in the future. In line with this, the lockword offset is now used directly. Signed-off-by: Ben Thomas <ben@benthomas.ca>
Previously, the Power codegen assumed that the maximum size of an arraylet leaf in elements could be fit into a 16-bit immediate field. This may not always be true, so could lead to incorrect behaviour. Handling for when the maximum number of elements is > 0x7fff has now been added. Signed-off-by: Ben Thomas <ben@benthomas.ca>
|
@pshipton FYI |
pshipton
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a double-delivery of #9803 for the purposes of having these fixes included in the 0.21.0 release.