This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Revert "Upgrade maven-bundle-plugin to 5.1.1 to make EBR compatible w… #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDK-15-EA per the issue here: https://github.com/bndtools/bnd/wiki/Changes-in-5.1.1#fixes-since-510" This reverts commit 7edf5ab. It breaks generation of capabilities as described in upstream issue https://issues.apache.org/jira/browse/FELIX-6337 Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
|
@guw We need this ASAP so we can get not-broken Orbit build. |
|
@nikhilnanivadekar I had to revert the upgrade for now. |
|
@guw I thought the maven bundle plug-in had fixed the bug since 5.1.0. And we had upgraded it to 5.1.1. I am a bit confused, is 5.1.1 also broken? If it is we should file a bug report. |
|
Never mind, I clicked through all the links above and realized it’s still an issue. We will wait for their fix. |
|
@guw , I've triggered https://ci.eclipse.org/ebr/job/ebr-maven-plugins/ as it seems that deploys to https://repo.eclipse.org/content/repositories/ebr-snapshots/org/eclipse/ebr/ebr-maven-plugin/1.3.0-SNAPSHOT/ . We need this to rebuild latest felix.scr correctly. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ith JDK-15-EA per the issue here: https://github.com/bndtools/bnd/wiki/Changes-in-5.1.1#fixes-since-510"
This reverts commit 7edf5ab.
It breaks generation of capabilities as described in upstream issue https://issues.apache.org/jira/browse/FELIX-6337