Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show of packages / bundles that are already imported. #146

Open
laeubi opened this issue Jun 8, 2022 · 5 comments · May be fixed by #1195
Open

Show of packages / bundles that are already imported. #146

laeubi opened this issue Jun 8, 2022 · 5 comments · May be fixed by #1195

Comments

@laeubi
Copy link
Contributor

laeubi commented Jun 8, 2022

One really annoying feature is that PDE hides bundles/packages if they are already imported.

This leads to strange behavior, e.g. I can't import a package if it is (transitively) imported and even worse the search is simply empty.

It would be good if PDE at least shows the package (maybe with a hint: already imported by...)

@vogella
Copy link
Contributor

vogella commented Jun 8, 2022

+1, maybe showing them as grayed out / inactive. At least this way the user could see that it is already included.

@lathapatil
Copy link
Contributor

I can make it look like below but I still need a hint on styling the text (grey out) inside the dialog because the underlying class responsible for the packages list is FilteredList.java which intern not using SWT label but a custom one.

2024-01-12_13h31_22.mp4

Empty package image used for this may look inappropriate ? then it can be reverted to package image.

@laeubi
Copy link
Contributor Author

laeubi commented Jan 12, 2024

@lathapatil thanks for working on this, this looks fine to me, just a space between version and the text would be good.
Also it would be nice to have a checkbox (enabled by default) that reads "Show already imported packages"

@lathapatil
Copy link
Contributor

lathapatil commented Jan 12, 2024

@lathapatil thanks for working on this, this looks fine to me, just a space between version and the text would be good. Also it would be nice to have a checkbox (enabled by default) that reads "Show already imported packages"

Thanks for the quick feedback .

does it make sense to disable 'ADD' button during multi-selection if one of the selection is already imported ?

If this is not ok.. we can enable 'ADD' button even though one of the selection is already imported and can handle the addition of packages at backend

Should this behavior be applied for "Required plug-ins" and "Exported Packages" as well?

@laeubi
Copy link
Contributor Author

laeubi commented Jan 12, 2024

I think the button should only be disabled if ALL packages are already imported.

Should this behavior be applied for "Required plug-ins" and "Exported Packages" as well?

Yes that would be good.

lathapatil added a commit to lathapatil/eclipse.pde that referenced this issue Mar 13, 2024
lathapatil added a commit to lathapatil/eclipse.pde that referenced this issue Mar 13, 2024
lathapatil added a commit to lathapatil/eclipse.pde that referenced this issue Oct 22, 2024
lathapatil added a commit to lathapatil/eclipse.pde that referenced this issue Oct 22, 2024
Fixes eclipse-pde#146
Files not present in branch but changes are visible in github commit
lathapatil added a commit to lathapatil/eclipse.pde that referenced this issue Oct 23, 2024
Fixes eclipse-pde#146
Files not present in branch but changes are visible in github commit
Missed code/files while Conflict resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants