-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show of packages / bundles that are already imported. #146
Comments
+1, maybe showing them as grayed out / inactive. At least this way the user could see that it is already included. |
I can make it look like below but I still need a hint on styling the text (grey out) inside the dialog because the underlying class responsible for the packages list is FilteredList.java which intern not using SWT label but a custom one. 2024-01-12_13h31_22.mp4Empty package image used for this may look inappropriate ? then it can be reverted to package image. |
@lathapatil thanks for working on this, this looks fine to me, just a space between version and the text would be good. |
Thanks for the quick feedback . does it make sense to disable 'ADD' button during multi-selection if one of the selection is already imported ? If this is not ok.. we can enable 'ADD' button even though one of the selection is already imported and can handle the addition of packages at backend Should this behavior be applied for "Required plug-ins" and "Exported Packages" as well? |
I think the button should only be disabled if ALL packages are already imported.
Yes that would be good. |
Fixes eclipse-pde#146 Files not present in branch but changes are visible in github commit
Fixes eclipse-pde#146 Files not present in branch but changes are visible in github commit Missed code/files while Conflict resolution
One really annoying feature is that PDE hides bundles/packages if they are already imported.
This leads to strange behavior, e.g. I can't import a package if it is (transitively) imported and even worse the search is simply empty.
It would be good if PDE at least shows the package (maybe with a hint: already imported by...)
The text was updated successfully, but these errors were encountered: