Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write latest master build to downloads.eclipse.org #1060

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

akurtakov
Copy link
Member

Using https://download.eclipse.org/pde/builds/master/ as destination so it can be tested more broadly.
Mainly motivated to have a permanent download space which wasn't there as discovered in
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4172

@akurtakov
Copy link
Member Author

akurtakov commented Jan 18, 2024

@HannesWell wdyt? It's not giving any immediate benefits but it's one more step towards decoupling it from Platform.
Once this is in I plan on trying to add this repo in releng.aggregator and have the pde bundles be used from it instead of rebuilt during I-build.

Copy link

github-actions bot commented Jan 18, 2024

Test Results

   291 files  +   98     291 suites  +98   59m 54s ⏱️ + 27m 32s
 3 526 tests ±    0   3 468 ✅ +    2   58 💤  -  1  0 ❌  - 1 
10 875 runs  +3 677  10 699 ✅ +3 608  176 💤 +70  0 ❌  - 1 

Results for commit 6b3dcd5. ± Comparison against base commit f26df87.

♻️ This comment has been updated with latest results.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HannesWell wdyt? It's not giving any immediate benefits but it's one more step towards decoupling it from Platform.

Regarding this change, the binaries published should probably be jar-signed, shouldn't they?

Once this is in I plan on trying to add this repo in releng.aggregator and have the pde bundles be used from it instead of rebuilt during I-build.

Please don't do that before the cycles are cut. As long as there are other plugins in the SDK that depend on PDE, we should not do that. Otherwise we probably make the situation worse than it is now.

Looking at the Dependencies of pde.build (which is the plugin on that actually every other plugin in PDE depends on) I see mainly the following plugins with PDE dependencies:

  • org.eclipse.e4.tools
  • org.eclipse.e4.tools.emf.editor3x
  • org.eclipse.e4.tools.emf.ui

Plus ant.test.core/ui and jdt.apt.tests.
And having a quick look at that I would say that it is probably possible, but not trivial to change.

grafik

Jenkinsfile Outdated Show resolved Hide resolved
@laeubi
Copy link
Contributor

laeubi commented Jan 19, 2024

I see mainly the following plugins with PDE dependencies:

See

@akurtakov akurtakov force-pushed the master branch 3 times, most recently from c4118a5 to 1f03229 Compare January 26, 2024 17:15
@akurtakov
Copy link
Member Author

Regarding this change, the binaries published should probably be jar-signed, shouldn't they?

Also done.

Jenkinsfile Outdated Show resolved Hide resolved
@laeubi
Copy link
Contributor

laeubi commented Jan 28, 2024

Please don't do that before the cycles are cut. As long as there are other plugins in the SDK that depend on PDE, we should not do that. Otherwise we probably make the situation worse than it is now.

See

@laeubi
Copy link
Contributor

laeubi commented Jan 28, 2024

@akurtakov now the e4 tools are part of this repo we maybe want to include the features in the updatesite

@akurtakov
Copy link
Member Author

@akurtakov now the e4 tools are part of this repo we maybe want to include the features in the updatesite

Should be done now.

Using https://download.eclipse.org/pde/builds/master/ as destination so
it can be tested more broadly.
Mainly motivated to have a permanent download space which wasn't there
as discovered in
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4172
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a first attempt.

But on the long run we should discuss and have a more sophisticated repo structure.

@akurtakov
Copy link
Member Author

Looks good for a first attempt.

But on the long run we should discuss and have a more sophisticated repo structure.

Definetly, esp with regards of releases and etc. We are far from such state yet and every step that would make things easier to go to the next step while not causing issue for anything else should be taken.

Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@akurtakov akurtakov merged commit 38f32ec into eclipse-pde:master Jan 31, 2024
17 checks passed
@laeubi
Copy link
Contributor

laeubi commented Jan 31, 2024

I don't know yet why but now master build fails :-\

https://ci.eclipse.org/pde/job/eclipse.pde/job/master/554/

@iloveeclipse
Copy link
Member

See #1095

@akurtakov
Copy link
Member Author

It still fails even after the test fix is in and this is most likely caused by signing as it fails in the very same way as figured in eclipse-platform/eclipse.platform.releng.aggregator#1673 .

@akurtakov
Copy link
Member Author

If I fail to figure what's going wrong with comparison in the next few hours I'll revert the signing part only.

akurtakov added a commit to akurtakov/eclipse.pde.ui that referenced this pull request Jan 31, 2024
After eclipse-pde#1060 got merged
the build failed due to signing. This is similar issue like
eclipse-platform/eclipse.platform.releng.aggregator#1673 so this is a
simple check whether a "touch" would be enough.
akurtakov added a commit to akurtakov/eclipse.pde.ui that referenced this pull request Jan 31, 2024
After eclipse-pde#1060 got merged
the build failed due to signing. This is similar issue like
eclipse-platform/eclipse.platform.releng.aggregator#1673 so this is a
simple check whether a "touch" would be enough.
akurtakov added a commit that referenced this pull request Jan 31, 2024
After #1060 got merged
the build failed due to signing. This is similar issue like
eclipse-platform/eclipse.platform.releng.aggregator#1673 so this is a
simple check whether a "touch" would be enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants