BundleComponent.isValidBundle() should no throw if reading manifest fail #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/request-license-review |
License review requests: After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
laeubi
force-pushed
the
api_tools_fix_valid_bundle
branch
2 times, most recently
from
0c9b4b5
to
2c10a35
Compare
Currently BundleComponent.isValidBundle() is used to check if a bundle is valid and should be considered for the baseline. If the location points to something that chase no manifest at all (or an invalid manifest) this currently an exception even though the API doc clearly states that "Validity is determined via the existence of a readable manifest file" This now adds two checks 1) the location points to a file that exits and is larger than zero bytes 2) parsing the manifest from the location do not throw an exception
laeubi
force-pushed
the
api_tools_fix_valid_bundle
branch
from
2c10a35
to
2773e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently BundleComponent.isValidBundle() is used to check if a bundle is valid and should be considered for the baseline. If the location points to something that chase no manifest at all (or an invalid manifest) this currently an exception even though the API doc clearly states that "Validity is determined via the existence of a readable manifest file"
This now adds two checks
This error can be seen for example here:
https://ci.eclipse.org/equinox/job/p2/job/PR-524/8/console