Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert" Set the selection to 1st CTabItem when it is created.… #1164

Merged
merged 1 commit into from
May 10, 2024

Conversation

deepika-u
Copy link
Contributor

…" (#1087)"

This reverts commit 2a51e8c.

For approvals for this pr, please refer to #1044

This means we are resuming pr change done under #1044 for issue #46 back once again with changes in platform and ui with below prs in place.

eclipse-platform/eclipse.platform.ui#1796
eclipse-platform/eclipse.platform#1287

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Test Results

   418 files  ±0     418 suites  ±0   7m 18s ⏱️ -9s
 4 121 tests ±0   4 113 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 313 runs  ±0  16 221 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit 6ae8fe7. ± Comparison against base commit 3e830bf.

♻️ This comment has been updated with latest results.

@fedejeanne fedejeanne merged commit 49c04a7 into eclipse-platform:master May 10, 2024
14 checks passed
@deepika-u
Copy link
Contributor Author

Thanks fedejeanne.

@deepika-u
Copy link
Contributor Author

Verified this issue and works as expected on below build.

Eclipse SDK
Version: 2024-06 (4.32)
Build id: I20240512-1800
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Oracle Corporation
Java runtime version: 22+36-2370
Java version: 22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants