Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable viewer limits by default #1425

Closed
iloveeclipse opened this issue Dec 15, 2023 · 0 comments · Fixed by #1426
Closed

Enable viewer limits by default #1425

iloveeclipse opened this issue Dec 15, 2023 · 0 comments · Fixed by #1426
Assignees
@iloveeclipse
Labels
enhancement New feature or request
Milestone
4.31 M1

Comments

@iloveeclipse
Copy link
Member

As discussed in #818, we had few open issues and/or concerns regarding "viewer limit" functionality merged in 4.30.
It was decided to postpone enablement to the next release M1.

Here we are, I will push a PR that sets the default limit to 1000, which is what we believe the most practical value on most platforms to avoid UI freezes in large viewers.
@iloveeclipse iloveeclipse added the enhancement New feature or request label Dec 15, 2023
@iloveeclipse iloveeclipse added this to the 4.31 M1 milestone Dec 15, 2023
@iloveeclipse iloveeclipse self-assigned this Dec 15, 2023
iloveeclipse added a commit to iloveeclipse/eclipse.platform.ui that referenced this issue Dec 15, 2023
@iloveeclipse
Enable viewer limits by default
1f7f025 
Set default workbench preference for the view limit to 1000, which is
what we believe the most practical value on most platforms to avoid UI
freezes in large viewers.

Note: this limit can also be disabled in products by specifying
`org.eclipse.ui.workbench/largeViewLimit=0` in the
plugin_customization.ini file.

Fixes eclipse-platform#1425
This was referenced Dec 15, 2023
Merged
Closed
iloveeclipse added a commit that referenced this issue Dec 15, 2023
@iloveeclipse
Enable viewer limits by default
36358bd 
Set default workbench preference for the view limit to 1000, which is
what we believe the most practical value on most platforms to avoid UI
freezes in large viewers.

Note: this limit can also be disabled in products by specifying
`org.eclipse.ui.workbench/largeViewLimit=0` in the
plugin_customization.ini file.

Fixes #1425
@iloveeclipse iloveeclipse mentioned this issue Dec 19, 2023
Merged
iloveeclipse added a commit to eclipse-platform/www.eclipse.org-eclipse that referenced this issue Dec 19, 2023
@iloveeclipse
Added N&N about viewer limit
3b38381 
See
eclipse-platform/eclipse.platform.ui#1425
eclipse-platform/eclipse.platform.ui#818
@marcushoepfner marcushoepfner mentioned this issue Feb 5, 2024
Open
amartya4256 pushed a commit to amartya4256/eclipse.platform.ui that referenced this issue Feb 8, 2024
@iloveeclipse @amartya4256
Enable viewer limits by default
55900f3 
Set default workbench preference for the view limit to 1000, which is
what we believe the most practical value on most platforms to avoid UI
freezes in large viewers.

Note: this limit can also be disabled in products by specifying
`org.eclipse.ui.workbench/largeViewLimit=0` in the
plugin_customization.ini file.

Fixes eclipse-platform#1425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iloveeclipse iloveeclipse

Labels
enhancement New feature or request
Projects
None yet
Milestone
4.31 M1
Development

Successfully merging a pull request may close this issue.

Enable viewer limits by default iloveeclipse/eclipse.platform.ui
1 participant
@iloveeclipse