Improve LaunchConfigurationTabGroupViewerTest #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some tests to check that no unnecessary de/activation of tabs is happening and add some assertions to existing tests too. These improvements are necessary in order to guarantee that fixing eclipse-platform/eclipse.platform.swt#46 do not change the existing behavior of LaunchConfigurationTabGroupViewer. Contributes to eclipse-platform#859 Contributes to eclipse-platform/eclipse.platform.swt#46
fedejeanne
deleted the
add_tests_to_LaunchConfigurationTabGroupViewerTest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/eclipse-platform/eclipse.platform/pull/1287/files#r1553193527
This PR makes sure that points 5 and 6 hold true now and that points 3 and 4 still hold true after applying a fix for eclipse-platform/eclipse.platform.swt#46