Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate compare performance tests to JUnit 5 #749

Merged

Conversation

HeikoKlare
Copy link
Contributor

The performance test in org.eclipse.compare.tests still relies on the JUnit 3 PerformanceTestCase. This change migrates the compare performance test and test suite to JUnit 5.

Note that the performance tests are not executed in CI builds, so the change will probably not have any effect that is automatically validated.

The performance test in org.eclipse.compare.tests still relies on the
JUnit 3 PerformanceTestCase. This change migrates the compare
performance test and test suite to JUnit 5.
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Test Results

       90 files  +     54         90 suites  +54   55m 11s ⏱️ + 6m 36s
  3 778 tests +1 035    3 775 ✔️ +1 036    3 💤 ±0  0  - 1 
11 337 runs  +3 105  11 310 ✔️ +3 106  27 💤 ±0  0  - 1 

Results for commit 2466dc2. ± Comparison against base commit cfb3c5f.

This pull request removes 126 and adds 1161 tests. Note that renamed tests count towards both.
org.eclipse.compare.tests.AsyncExecTests ‑ testCancelOnRequeue
org.eclipse.compare.tests.AsyncExecTests ‑ testQueueAdd
org.eclipse.compare.tests.AsyncExecTests ‑ testWorker
org.eclipse.compare.tests.CompareFileRevisionEditorInputTest ‑ testPrepareCompareInputWithNonLocalResourceTypedElements
org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptorForTextType_StreamAccessor
org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_TextType_NotStreamAccessor
org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_UnknownType
org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFFX
org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFTX
org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFXF
…
AllCompareTests org.eclipse.compare.tests.AsyncExecTests ‑ testCancelOnRequeue
AllCompareTests org.eclipse.compare.tests.AsyncExecTests ‑ testQueueAdd
AllCompareTests org.eclipse.compare.tests.AsyncExecTests ‑ testWorker
AllCompareTests org.eclipse.compare.tests.CompareFileRevisionEditorInputTest ‑ testPrepareCompareInputWithNonLocalResourceTypedElements
AllCompareTests org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptorForTextType_StreamAccessor
AllCompareTests org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_TextType_NotStreamAccessor
AllCompareTests org.eclipse.compare.tests.CompareUIPluginTest ‑ testFindContentViewerDescriptor_UnknownType
AllCompareTests org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFFX
AllCompareTests org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFTX
AllCompareTests org.eclipse.compare.tests.ContentMergeViewerTest ‑ testFFXF
…

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare marked this pull request as ready for review October 20, 2023 08:24
@akurtakov akurtakov merged commit 4e9eaab into eclipse-platform:master Oct 27, 2023
16 checks passed
@HeikoKlare HeikoKlare deleted the compare-performance-tests-junit5 branch November 4, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants