Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XmlProcessorFactoryTest #761

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Oct 24, 2023

And createDocumentBuilderIgnoringDOCTYPE() does not load remote DTDs see https://github.com/eclipse-jdt/eclipse.jdt.debug/issues

@jukzi jukzi requested a review from HannesWell October 24, 2023 12:08
@jukzi
Copy link
Contributor Author

jukzi commented Oct 24, 2023

@HannesWell
test copied from PDE and extended

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Test Results

     530 files   -     1       530 suites   - 1   1h 8m 37s ⏱️ + 7m 54s
  3 792 tests +  19    3 788 ✔️ +  18    3 💤 ±0  1 +1 
11 184 runs   - 153  11 157 ✔️  - 153  26 💤  - 1  1 +1 

For more details on these failures, see this check.

Results for commit c4aa439. ± Comparison against base commit e8470ff.

♻️ This comment has been updated with latest results.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already wondered why the Tests are still in PDE.
Do you want to create a PR to remove them from PDE?

The change itself looks good, but the Test-class misses the Copyright header (is probably already missing in PDE).

jukzi pushed a commit to jukzi/eclipse.pde that referenced this pull request Oct 25, 2023
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

jukzi pushed a commit to jukzi/eclipse.pde that referenced this pull request Oct 25, 2023
jukzi pushed a commit to eclipse-pde/eclipse.pde that referenced this pull request Oct 25, 2023
And createDocumentBuilderIgnoringDOCTYPE() does not load remote DTDs.

see eclipse-jdt/eclipse.jdt.debug#323
@HannesWell
Copy link
Member

Is this ready for submission?

alshamams pushed a commit to alshamams/eclipse.pde that referenced this pull request Oct 31, 2023
@jukzi jukzi merged commit d0ec0a8 into eclipse-platform:master Nov 2, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants