-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XmlProcessorFactoryTest #761
Conversation
@HannesWell |
82bd7d9
to
1027060
Compare
Test Results 530 files - 1 530 suites - 1 1h 8m 37s ⏱️ + 7m 54s For more details on these failures, see this check. Results for commit c4aa439. ± Comparison against base commit e8470ff. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already wondered why the Tests are still in PDE.
Do you want to create a PR to remove them from PDE?
The change itself looks good, but the Test-class misses the Copyright header (is probably already missing in PDE).
1027060
to
ba91a07
Compare
moved to platform eclipse-platform/eclipse.platform#761
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks.
moved to platform eclipse-platform/eclipse.platform#761
ba91a07
to
270a60e
Compare
moved to platform eclipse-platform/eclipse.platform#761
270a60e
to
1ec5c07
Compare
And createDocumentBuilderIgnoringDOCTYPE() does not load remote DTDs. see eclipse-jdt/eclipse.jdt.debug#323
1ec5c07
to
c4aa439
Compare
Is this ready for submission? |
moved to platform eclipse-platform/eclipse.platform#761
And createDocumentBuilderIgnoringDOCTYPE() does not load remote DTDs see https://github.com/eclipse-jdt/eclipse.jdt.debug/issues