Deduplicate launch configs #800
Conversation
laeubi
force-pushed
the
dedup_launches
branch
2 times, most recently
from
28df400
to
c74bc29
Compare
The same launch config might be returned by multiple LaunchShortcutExtension and is then shown twice. This simply filter items that where already seen to deduplicate such entries. Fix eclipse-platform#527
laeubi
force-pushed
the
dedup_launches
branch
from
c74bc29
to
82bacbc
Compare
This fixes API error saying unnecessary version bump. The bundle was not published yet via IBuild, so we can revert. Regression from eclipse-platform#800
| @@ -2,7 +2,7 @@ Manifest-Version: 1.0 | |||
| Bundle-ManifestVersion: 2 | |||
| Bundle-Name: %pluginName | |||
| Bundle-SymbolicName: org.eclipse.debug.ui; singleton:=true | |||
| Bundle-Version: 3.18.300.qualifier | |||
| Bundle-Version: 3.18.400.qualifier | |||
There was a problem hiding this comment.
Once again bump was not needed.
Please always check version changes in the IDE as long as Tycho doesn't fully matches IDE functionality of API tooling.
Fix: https://github.com/eclipse-platform/eclipse.platform/pull/901/files
There was a problem hiding this comment.
IDE currently show false positives for me. I started a build before without bump and it claims it want a bump...
There was a problem hiding this comment.
Guess you weren't on latest master. The version was bumped in 0a5f0ff
There was a problem hiding this comment.
FYI, I would not trust the IDE's baseline information if you haven't deleted it and built it new:
eclipse-platform/eclipse.platform.releng.aggregator#1605 (comment)
There was a problem hiding this comment.
FYI, I would not trust the IDE's baseline information if you haven't deleted it and built it new:
Just in case: I'm not using Oomph for SDK development, I never update anything, I start everyday with latest nightly IBuild (if it was built at all).
There was a problem hiding this comment.
Sorry the comment was intended for @laeubi
This fixes API error saying unnecessary version bump. The bundle was not published yet via IBuild, so we can revert. Regression from #800
This fixes API error saying unnecessary version bump. The bundle was not published yet via IBuild, so we can revert. Regression from eclipse-platform#800
The same launch config might be returned by multiple LaunchShortcutExtension and is then shown twice.
This simply filter items that where already seen to deduplicate such entries.
Fix #527