Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TeamPrivateMemberTest #843

Merged

Conversation

HeikoKlare
Copy link
Contributor

  • Replaces all try-catch blocks with rethrown exceptions
  • Removes all further JUnit-3-specific functionality
  • Simplifies and improves all assertions by moving to matchers

This is part of preparatory work for migrating the ResourceTests to JUnit 4.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Test Results

     591 files  ±0       591 suites  ±0   1h 13m 7s ⏱️ - 8m 6s
  3 842 tests ±0    3 836 ✔️ ±0    5 💤 ±0  1 ±0 
12 132 runs  ±0  12 095 ✔️ ±0  36 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit c3d219a. ± Comparison against base commit 46ebc37.

♻️ This comment has been updated with latest results.

* Replaces all try-catch blocks with rethrown exceptions
* Removes all further JUnit-3-specific functionality
* Simplifies and improves all assertions by moving to matchers
@HeikoKlare HeikoKlare merged commit eb9ddc9 into eclipse-platform:master Nov 29, 2023
15 of 16 checks passed
@HeikoKlare HeikoKlare deleted the improve-teamprivatemembertest branch November 29, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant