Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MarkerTest #844

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

HeikoKlare
Copy link
Contributor

  • Replaces all try-catch blocks with rethrown exceptions or assertThrows
  • Removes all further JUnit-3-specific functionality from MarkerTest
  • Simplifies and improves all assertions by moving to matchers

This is part of preparatory work for migrating the ResourceTests to JUnit 4.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Test Results

     591 files  ±0       591 suites  ±0   1h 11m 14s ⏱️ + 4m 4s
  3 842 tests ±0    3 837 ✔️ ±0    5 💤 ±0  0 ±0 
12 132 runs  ±0  12 096 ✔️ ±0  36 💤 ±0  0 ±0 

Results for commit 9c2eaae. ± Comparison against base commit eb9ddc9.

♻️ This comment has been updated with latest results.

* Replaces all try-catch blocks with rethrown exceptions or assertThrows
* Removes all further JUnit-3-specific functionality from MarkerTest
* Simplifies and improves all assertions by moving to matchers
@HeikoKlare HeikoKlare merged commit 0428204 into eclipse-platform:master Nov 30, 2023
16 checks passed
@HeikoKlare HeikoKlare deleted the improve-markertest branch November 30, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant