Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade docker build process to use docker compose v2 #4399

Closed
abrokenjester opened this issue Feb 3, 2023 · 0 comments · Fixed by #4407
Closed

Upgrade docker build process to use docker compose v2 #4399

abrokenjester opened this issue Feb 3, 2023 · 0 comments · Fixed by #4407
Assignees
@abrokenjester
Labels
docker 🔧 internal task a project workflow / setup task not directly impacting end users

Comments

@abrokenjester
Copy link
Contributor

Our current docker build scripts still assume docker-compose v1. Version 2 has been out for a while now though, is stable, and the default version installed on many distros. However, it is not fully backward compatible, so our scripts will need a few adjustments:

  • the invocation has changed from docker-compose to docker compose (no dash)
  • the generated name for the image when using docker compose build has changed from the convention in v1, which breaks our build.sh script when trying to set tags
@abrokenjester abrokenjester added 🔧 internal task a project workflow / setup task not directly impacting end users docker labels Feb 3, 2023
@abrokenjester abrokenjester self-assigned this Feb 5, 2023
@abrokenjester abrokenjester mentioned this issue Feb 5, 2023
Merged
5 tasks
abrokenjester added a commit that referenced this issue Feb 5, 2023
@abrokenjester
GH-4399 adjust docker setup to work with docker compose 2
a2bcf6b 
- tested with Docker version 23.0.0, Docker Compose version v2.15.1
@abrokenjester abrokenjester mentioned this issue Feb 5, 2023
Merged
5 tasks
erikgb added a commit to erikgb/rdf4j that referenced this issue Feb 6, 2023
@erikgb
eclipse-rdf4jGH-4399
a8c31de
erikgb added a commit to erikgb/rdf4j that referenced this issue Feb 6, 2023
@erikgb
eclipse-rdf4jGH-4399
96d8dbc
hmottestad added a commit that referenced this issue Feb 13, 2023
@hmottestad
GH-4399 fix typo
debcc9e
abrokenjester added a commit that referenced this issue Feb 19, 2023
@abrokenjester
GH-4399 use docker compose (no dash) consistently
30d1bad
abrokenjester added a commit that referenced this issue Feb 19, 2023
@abrokenjester
GH-4399 adjust docker setup to work with docker compose 2 (#4407)
a5d962d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrokenjester abrokenjester

Labels
docker 🔧 internal task a project workflow / setup task not directly impacting end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-4399 adjust docker setup to work with docker compose 2 eclipse-rdf4j/rdf4j
1 participant
@abrokenjester