Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-4446: Replace tomcat7-maven-plugin with jetty-maven-plugin #4447

Merged

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Feb 22, 2023

GitHub issue resolved: #4446

Briefly describe the changes proposed in this PR:

This PR replaces the maven plugin that can be used to run server/workbench in a local development environment. I am now able to run server in standalone mode by executing mvn jetty:run from the server module, and workbench+server if running from the workbench module.

Also cleaning up some dependency issues detected by duplicate class detection on Jetty startup. There is still a problem with duplicate commons-logging classes, but that requires more delicate work to fix. Please let me know if you want the dep-changes in a dedicated PR. I have made an attempt in #4443, but IMO it makes more sense to do it here - when actually running the applications.


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

Copy link
Contributor

@barthanssens barthanssens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maven Jetty plugin is also covered by Eclipse license, so that's fine in terms of IP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants