-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest): Added new endpoints to update attachment info of Project, Component, Release #1190
feat(rest): Added new endpoints to update attachment info of Project, Component, Release #1190
Conversation
89c045b
to
b50f1f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code, suggested some minor changes.
Tested the changes, and all the 3 endpoints working as expected.
...rce-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/ProjectSpecTest.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/eclipse/sw360/rest/resourceserver/attachment/Sw360AttachmentService.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/eclipse/sw360/rest/resourceserver/attachment/Sw360AttachmentService.java
Outdated
Show resolved
Hide resolved
… Component, Release Signed-off-by: Jaideep Palit <jaideep.palit@siemens.com>
b50f1f6
to
4140a8a
Compare
Thanks for review and test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
Tested the PR again after changes, and is working fine.
Is there a reason that the patch url is different from the get url? To get the attachment infos you need to use It would also be nice if attachment infos could be updated through the |
so, it is about the "s" ... I agree, but I am not sure how much trouble we cause will there be in case we change it |
Issue: closes #1189
How To Test?
Checklist
Must:
Signed-off-by: Jaideep Palit jaideep.palit@siemens.com