Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language pack install via Configure Display Language command broken #13556

Closed
msujew opened this issue Apr 3, 2024 · 1 comment · Fixed by #13557
Closed

Language pack install via Configure Display Language command broken #13556

msujew opened this issue Apr 3, 2024 · 1 comment · Fixed by #13557
Labels
localization issues related to localization/internalization/nls

Comments

@msujew
Copy link
Member

msujew commented Apr 3, 2024

Bug Description:

After #13421 the arguments of the VSCodeExtensionUri.fromId method has changed without adapting the caller site. This results in an invalid URI that doesn't lead to a valid extension.

Steps to Reproduce:

  1. Run the Configure Display Language command
  2. Select a language that isn't installed yet.
  3. Observe the error message in the console: Uncaught (in promise) Error: Deployment of extension with ID vscode-extension://vscode-language-pack-zh-hans/MS-CEINTL failed.

Additional Information

@msujew msujew added the localization issues related to localization/internalization/nls label Apr 3, 2024
@msujew msujew mentioned this issue Apr 3, 2024
1 task
@tsmaeder
Copy link
Contributor

The URI that is being requested is https://open-vsx.org/api/-/query?extensionId=vscode-language-pack-de&extensionVersion=MS-CEINTL&includeAllVersions=true. You get a 400 error on this uri. Note that the uri is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants