Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http file miss highlight and codelens not effect #6192

Closed
502647092 opened this issue Sep 16, 2019 · 5 comments
Closed

http file miss highlight and codelens not effect #6192

502647092 opened this issue Sep 16, 2019 · 5 comments
Labels
bug bugs found in the application monaco issues related to monaco plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@502647092
Copy link
Contributor

Description

recent versions cause http file miss highlight and codelens not effect

Reproduction Steps

  • Install ext vscode:extension/humao.rest-client
  • create simple http file
GET http://google.com

temp

  • here are two problem
      1. http file miss highlight
      1. codelens not effect , but after manual send request it will active

OS and Theia version:
Diagnostics:

@akosyakov akosyakov added bug bugs found in the application monaco issues related to monaco plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Sep 16, 2019
@vince-fugnitto
Copy link
Member

vince-fugnitto commented Sep 19, 2019

It works correctly initially, but once the application is reloaded it loses both the highlighting and codelens.

Initially

Screen Shot 2019-09-19 at 9 42 32 AM

After Reload

Screen Shot 2019-09-19 at 9 42 41 AM

@akosyakov it's quite possibly fixed by your PR #6159.
I'll try it out 😄

@akosyakov
Copy link
Member

akosyakov commented Sep 20, 2019

I see an error in console:

root ERROR An invalid preference schema was rejected: data.properties['rest-client.largeResponseBodySizeLimitInMB'].exclusiveMinimum should be number

Could be a bug in vscode extension? We should be more tolerant though and does not ignore the whole schema, but only bogus attribute. cc @AlexTugarev

@akosyakov
Copy link
Member

I also see:

logger-protocol.ts:112 root ERROR TypeError: Cannot assign to read only property 'other' of object '#<Object>'
    at https://3000-f6ab6d92-f168-48b1-8d7e-7a90981b9e35.ws-eu0.gitpod.io/vs/editor/editor.main.js:14679:46
    at Array.forEach (<anonymous>)
    at mixin (https://3000-f6ab6d92-f168-48b1-8d7e-7a90981b9e35.ws-eu0.gitpod.io/vs/editor/editor.main.js:14672:33)
    at https://3000-f6ab6d92-f168-48b1-8d7e-7a90981b9e35.ws-eu0.gitpod.io/vs/editor/editor.main.js:14676:29
    at Array.forEach (<anonymous>)
    at Object.mixin (https://3000-f6ab6d92-f168-48b1-8d7e-7a90981b9e35.ws-eu0.gitpod.io/vs/editor/editor.main.js:14672:33)
    at Configuration.CommonEditorConfiguration.updateOptions (https://3000-f6ab6d92-f168-48b1-8d7e-7a90981b9e35.ws-eu0.gitpod.io/vs/editor/editor.main.js:81298:40)
    at StandaloneEditor.CodeEditorWidget.updateOptions (https://3000-f6ab6d92-f168-48b1-8d7e-7a90981b9e35.ws-eu0.gitpod.io/vs/editor/editor.main.js:103757:33)
    at StandaloneEditor.updateOptions (https://3000-f6ab6d92-f168-48b1-8d7e-7a90981b9e35.ws-eu0.gitpod.io/vs/editor/editor.main.js:126146:44)
    at MonacoEditorProvider.push.../../packages/monaco/lib/browser/monaco-editor-provider.js.MonacoEditorProvider.updateMonacoEditorOptions (https://3000-f6ab6d92-f168-48b1-8d7e-7a90981b9e35.ws-eu0.gitpod.io/29.bundle.js:1262:33)

Maybe caused by the new Monaco version or recent preferences refactoring.

@akosyakov
Copy link
Member

@502647092 @vince-fugnitto Is it still the issue?

@akosyakov akosyakov removed their assignment Dec 2, 2019
@502647092
Copy link
Contributor Author

@akosyakov not have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application monaco issues related to monaco plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

3 participants