terminal: fix split-terminal visibility
#12626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes the terminal `split-terminal` toolbar item from appearing in other views when the terminal is active. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
|
cc @rschnekenbu do you mind reviewing, the changes from #12358 were still problematic on master. |
|
@vince-fugnitto, sure, i'll run the review today. |
msujew
approved these changes
Jun 23, 2023
dankeboy36
added a commit
to dankeboy36/arduino-ide
that referenced
this pull request
Jun 27, 2023
Ref: eclipse-theia/theia#12626/ Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
dankeboy36
added a commit
to dankeboy36/arduino-ide
that referenced
this pull request
Jun 28, 2023
Removed the toolbar contribution from the UI. Ref: eclipse-theia/theia#12626/ Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Jul 5, 2023
Removed the toolbar contribution from the UI. Ref: eclipse-theia/theia#12626/ Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
This was referenced Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The commit fixes #12357 which caused the
split-terminaltoolbar item from leaking to other views incorrectly when a terminal was currently visible.Related #12358.
Screenshots
Before:
After:
How to test
split-terminaltoolbar item is present and workssplit-terminaltoolbar item is not present in other views when a terminal is visiblesplit-terminaltoolbar item is present for subsequent terminalsReview checklist
Reminder for reviewers