Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Extend TextEditorLineNumbersStyle with Interval #13458

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

rschnekenbu
Copy link
Contributor

What it does

fixes #13447

The value Interval=3 was missing for the enum TextEditorLineNumberStyle. This PR adds this style, an extension can now set this style.

contributed on behalf of STMicroelectronics

How to test

  • Install provided extension, that adds a command 'Set Line Style Number'. It displays a quickpick menu to choose the line number style for the active text editor.
  • On theia master, try to switch the line style options on a text editor, especially choosing Interval. Nothing shows up.
  • After applying this PR, try again. Now setting the style to 'Interval' will display the line numbers every 10 lines + the current line number.

LineNumberStyle

Follow-ups

none

Review checklist

Reminder for reviewers

fixes eclipse-theia#13447

contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu rschnekenbu merged commit 82ada4b into eclipse-theia:master Mar 19, 2024
14 checks passed
@rschnekenbu rschnekenbu deleted the issues/13447 branch March 19, 2024 12:07
@jfaltermeier jfaltermeier added this to the 1.48.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] Extend TextEditorLineNumbersStyle with Interval
3 participants