Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Add PR review bot #9

Closed
egekorkan opened this issue Apr 8, 2020 · 3 comments
Closed

[enhancement] Add PR review bot #9

egekorkan opened this issue Apr 8, 2020 · 3 comments

Comments

@egekorkan
Copy link
Member

Similar to the way w3c repositories generate a static page for every PR, it would be nice to add a bot that does this for this repository. This might however need the involvement of someone from the Eclipse Foundation.
@danielpeintner
Copy link
Member

While I agree that an automatic and online process would be beneficial the process to check PRs locally is not a big deal either if hugo is setup properly

  1. check out PR
  2. run hugo server -D and check result

@egekorkan
Copy link
Member Author

A Netlify preview is added at https://thingweb-preview.netlify.app/ . Subsequent PRs should trigger PR previews to be generated

danielpeintner added a commit that referenced this issue Sep 29, 2023
@danielpeintner
Fix Typo
f9fbb74 
fixes an embarrassing typo
and
is a good test for #9
@danielpeintner danielpeintner mentioned this issue Sep 29, 2023
Merged
@danielpeintner
Copy link
Member

danielpeintner commented Sep 29, 2023 •
edited
Loading

I opened #51 and there is no preview shown...

Sorry, just took a bit 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielpeintner @egekorkan