-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Google Analytics #74
Implementing Google Analytics #74
Conversation
✅ Deploy Preview for thingweb-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
That should do the trick, nonetheless. If the plan is to stick to Hugo, I believe it would be really necessary to refactor the project, not just in regards to utilizing the newest version of Hugo but also revising how the styling is being handled. |
The PR looks good. It is not going to the main branch anyways but to my existing PR. If some give the OK, I will merge it and then trigger Eclipse Webmaster on the other PR. |
Google Analytics and Consent Process
|
The PR seems fine to me as well 👍. Once the consent banner is hidden it might be difficult for users to find the "Manage Cookies" link in the footer. Anyhow, I don't have a good alternative other than creating a dedicated cookie button in the bottom right corner or so... not sure if this might work better. An example what I mean can be seen on |
That could be a nice, simple solution. For the moment we could also specify on the banner that the user preferences can always be changed/updated on the link below. |
This would be actually good. Could you add it to the PR? |
BTW, the name of the PR "Implementing Google Analytics" does not convey the actual content. I think it should rather say "Implementing Consent Banner" |
@@ -57,9 +59,24 @@ | |||
</div> | |||
</footer> | |||
|
|||
<div class="analytics-banner hidden"> | |||
<div class="analytics-banner__disclaimer"> | |||
<h4>Google Analytics Consent</h4> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h4>Google Analytics Consent</h4> | |
<h4>Site Analytics Consent</h4> |
<p>We are an open-source project under the Eclipse Foundation. This means that without your consent | ||
we don't track anything at all and even with consent we don't track any personal information, we | ||
only look at the website usage statistics. For more details, check out the <a | ||
href="https://www.eclipse.org/legal/privacy.php">Eclipse Foundation Privacy Policy.</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
href="https://www.eclipse.org/legal/privacy.php">Eclipse Foundation Privacy Policy.</a></p> | |
href="https://www.eclipse.org/legal/privacy.php">Eclipse Foundation Privacy Policy.</a></p> | |
<p>You can change your preference later at the <b>Manage Consent</b> link in the footer.</p> |
We checked in the commiter's call and after those two small changes, we can merge and ping Webmaster |
@egekorkan the PR goes againts eclipse-thingweb:egekorkan-patch-2 |
Yes this is just updating the PR I already had. That PR is linked in the Eclipse helpdesk |
This is a new implementation of Google Analytics as well as the required consent banner to handle the necessary Google tags and therefore comply with any Eclipse Google Analytics Policy.